You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by di...@apache.org on 2023/12/31 11:47:21 UTC

(kafka) branch trunk updated: MINOR: Fix flaky test GroupMetadataManagerTest.testStaticMemberGetsBackAssignmentUponRejoin (#15100)

This is an automated email from the ASF dual-hosted git repository.

divijv pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d5aa341a185 MINOR: Fix flaky test GroupMetadataManagerTest.testStaticMemberGetsBackAssignmentUponRejoin (#15100)
d5aa341a185 is described below

commit d5aa341a185f4df23bf587e55bcda4f16fc511f1
Author: vamossagar12 <sa...@gmail.com>
AuthorDate: Sun Dec 31 17:17:14 2023 +0530

    MINOR: Fix flaky test GroupMetadataManagerTest.testStaticMemberGetsBackAssignmentUponRejoin (#15100)
    
    Reviewers: Divij Vaidya <di...@amazon.com>
    
    ---------
    
    Co-authored-by: Sagar Rao <sa...@Sagars-MacBook-Pro.local>
---
 .../kafka/coordinator/group/GroupMetadataManagerTest.java   | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java
index 832398f5b05..cfa1067d079 100644
--- a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java
+++ b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java
@@ -2191,11 +2191,8 @@ public class GroupMetadataManagerTest {
             .setMemberEpoch(-2)
             .build();
 
-        List<Record> expectedRecords = Collections.singletonList(
-            RecordHelpers.newCurrentAssignmentRecord(groupId, member2UpdatedEpoch)
-        );
-
-        assertEquals(result.records(), expectedRecords);
+        assertEquals(1, result.records().size());
+        assertRecordEquals(result.records().get(0), RecordHelpers.newCurrentAssignmentRecord(groupId, member2UpdatedEpoch));
 
         // Member 2 rejoins the group with the same instance id.
         CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> rejoinResult = context.consumerGroupHeartbeat(
@@ -2343,11 +2340,9 @@ public class GroupMetadataManagerTest {
             .Builder(member2)
             .setMemberEpoch(LEAVE_GROUP_STATIC_MEMBER_EPOCH)
             .build();
-        List<Record> expectedRecords = Collections.singletonList(
-            RecordHelpers.newCurrentAssignmentRecord(groupId, member2UpdatedEpoch)
-        );
 
-        assertEquals(result.records(), expectedRecords);
+        assertEquals(1, result.records().size());
+        assertRecordEquals(result.records().get(0), RecordHelpers.newCurrentAssignmentRecord(groupId, member2UpdatedEpoch));
     }
 
     @Test