You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/08/11 10:20:33 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
zhengruifeng opened a new pull request, #42451:
URL: https://github.com/apache/spark/pull/42451
### What changes were proposed in this pull request?
Add missing version information in DataFrame APIs
### Why are the changes needed?
to improve docs
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1292888463
##########
python/pyspark/sql/dataframe.py:
##########
@@ -4066,6 +4078,9 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> "
.. versionadded:: 3.5.0
+ .. versionchanged:: 3.5.0
Review Comment:
yes, this PR is just to following existing style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1292888387
##########
python/pyspark/sql/dataframe.py:
##########
@@ -3540,6 +3546,9 @@ def melt(
.. versionadded:: 3.4.0
+ .. versionchanged:: 3.4.0
Review Comment:
I double checked that `melt` in connect was added in https://github.com/apache/spark/commit/3212fa960169b1f1c29d63185aa96d535798fcc4, since 3.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1291421269
##########
python/pyspark/sql/dataframe.py:
##########
@@ -4066,6 +4078,9 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> "
.. versionadded:: 3.5.0
+ .. versionchanged:: 3.5.0
Review Comment:
Why would a user need to be notified of the change since it was added in version 3.5.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1291893263
##########
python/pyspark/sql/dataframe.py:
##########
@@ -4066,6 +4078,9 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> "
.. versionadded:: 3.5.0
+ .. versionchanged:: 3.5.0
Review Comment:
Yeah it's a bit odd but we have used this way to describe the support of Spark Connect. Let's keep it consistent for now, and fix all later separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
URL: https://github.com/apache/spark/pull/42451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42451:
URL: https://github.com/apache/spark/pull/42451#issuecomment-1676590123
thanks, merged to master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1291419624
##########
python/pyspark/sql/dataframe.py:
##########
@@ -3540,6 +3546,9 @@ def melt(
.. versionadded:: 3.4.0
+ .. versionchanged:: 3.4.0
Review Comment:
3.5.0？
##########
python/pyspark/sql/dataframe.py:
##########
@@ -3540,6 +3546,9 @@ def melt(
.. versionadded:: 3.4.0
+ .. versionchanged:: 3.4.0
Review Comment:
3.5.0？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1291169917
##########
python/pyspark/sql/dataframe.py:
##########
@@ -1304,7 +1307,10 @@ def limit(self, num: int) -> "DataFrame":
def offset(self, num: int) -> "DataFrame":
"""Returns a new :class: `DataFrame` by skipping the first `n` rows.
- .. versionadded:: 3.5.0
+ .. versionadded:: 3.4.0
Review Comment:
`offset` was first added to Python Client only in 3.4, and then added to vanilla one in 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org