You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/04/25 17:33:24 UTC
Review Request 58676: Logged when an agent (re-)registration request
is received.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58676/
-----------------------------------------------------------
Review request for mesos, Anindya Sinha and Benjamin Mahler.
Repository: mesos
Description
-------
- This log happens after the master has done initial validation but
before authorization, which is consistent with the (re-)register
framework code paths.
Diffs
-----
src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7
Diff: https://reviews.apache.org/r/58676/diff/1/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 58676: Logged when an agent (re-)registration
request is received.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58676/#review172960
-----------------------------------------------------------
Ship it!
Ship It!
- Anindya Sinha
On April 25, 2017, 5:33 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58676/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Anindya Sinha and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - This log happens after the master has done initial validation but
> before authorization, which is consistent with the (re-)register
> framework code paths.
>
>
> Diffs
> -----
>
> src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7
>
>
> Diff: https://reviews.apache.org/r/58676/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 58676: Logged when an agent (re-)registration
request is received.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58676/#review173037
-----------------------------------------------------------
Bad patch!
Reviews applied: [58676, 57731, 57730, 57710, 57535, 57534, 57520]
Failed command: python support/apply-reviews.py -n -r 57534
Error:
2017-04-26 10:11:50 URL:https://reviews.apache.org/r/57534/diff/raw/ [5343/5343] -> "57534.patch" [1]
error: patch failed: include/mesos/authorizer/authorizer.proto:189
error: include/mesos/authorizer/authorizer.proto: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17864/console
- Mesos Reviewbot
On April 25, 2017, 5:33 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58676/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Anindya Sinha and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - This log happens after the master has done initial validation but
> before authorization, which is consistent with the (re-)register
> framework code paths.
>
>
> Diffs
> -----
>
> src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7
>
>
> Diff: https://reviews.apache.org/r/58676/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>