[jira] Commented: (HADOOP-5867) Cleaning NNBench* off javac warnings

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710944#action_12710944 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5867:
------------------------------------------------

Patch looks mostly good.  Some nits:

- Each line should have 80 characters or less.  Some lines are too long, e.g.
{noformat}
+     * @return true if the method was able to sleep for <code>-startTime</code> without interruption; false otherwise
{noformat}

- Question: the rename and delete return values are ignored currently.  How about setting "success = fileSys.rename(..)"?

- Possible bug in the existing code: "totalTimeTPmS / successfulFileOps" below is an integer division
{code}
    double AverageExecutionTime = (totalTimeTPmS == 0) ?
        (double) successfulFileOps : 
        (double) (totalTimeTPmS / successfulFileOps);
{code}

> Cleaning NNBench* off javac warnings
> ------------------------------------
>
>                 Key: HADOOP-5867
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5867
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5867.patch, HADOOP-5867.patch
>
>
> These files have a number of javac 'class depricated' warnings 
>   src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBench.java
>   src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBenchWithoutMR.java
> It is possible to fix most of them plus make some readability improvements on the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.