You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/04 02:28:31 UTC
[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #71: [feat] Support expiration for chunked messages
BewareMyPower commented on code in PR #71:
URL: https://github.com/apache/pulsar-client-cpp/pull/71#discussion_r1013547938
##########
lib/ConsumerImpl.cc:
##########
@@ -319,6 +320,45 @@ void ConsumerImpl::unsubscribeAsync(ResultCallback originalCallback) {
}
}
+void ConsumerImpl::triggerCheckExpiredChunkedTimer() {
+ checkExpiredChunkedTimer_->expires_from_now(
+ boost::posix_time::milliseconds(expireTimeOfIncompleteChunkedMessageMs_));
+ std::weak_ptr<ConsumerImplBase> weakSelf{shared_from_this()};
+ checkExpiredChunkedTimer_->async_wait([this, weakSelf](const boost::system::error_code& ec) -> void {
+ auto self = weakSelf.lock();
+ if (!self) {
+ return;
+ }
+ if (ec) {
+ LOG_DEBUG(getName() << " Check expired chunked messages was failed or cancelled, code[" << ec
+ << "].");
+ return;
+ }
+ Lock lock(chunkProcessMutex_);
+ long currentTimeMs = TimeUtils::currentTimeMillis();
+ chunkedMessageCache_.removeOldestValuesIf(
+ [this, ¤tTimeMs](const std::string& uuid, const ChunkedMessageCtx& ctx) -> bool {
+ bool expired =
+ currentTimeMs > ctx.getReceivedTimeMs() + expireTimeOfIncompleteChunkedMessageMs_;
+ if (!expired) {
+ return false;
+ }
+ for (const MessageId& msgId : ctx.getChunkedMessageIds()) {
+ LOG_INFO("Removing expired chunk messages: uuid: " << uuid << ", messageId: " << msgId);
+ doAcknowledgeIndividual(msgId, [uuid, msgId](Result result) {
Review Comment:
Why did you capture `uuid` and `msgId` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org