You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/09/08 04:19:07 UTC
[GitHub] [commons-text] Stzx commented on a change in pull request #119:
TEXT-149: StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and
end of string
Stzx commented on a change in pull request #119: TEXT-149: StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string
URL: https://github.com/apache/commons-text/pull/119#discussion_r321991155
##########
File path: src/main/java/org/apache/commons/text/translate/CsvTranslators.java
##########
@@ -87,7 +87,7 @@ void translateWhole(final CharSequence input, final Writer out) throws IOExcepti
// deal with escaped quotes; ie) ""
out.write(StringUtils.replace(quoteless, CSV_ESCAPED_QUOTE_STR, CSV_QUOTE_STR));
} else {
- out.write(input.toString());
+ out.write(quoteless.toString());
Review comment:
Redundant `toString()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services