You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/19 19:52:21 UTC

[GitHub] [beam] aaltay commented on a change in pull request #14278: Add an option to create Dataflow piplines from a snapshot for python sdk

aaltay commented on a change in pull request #14278:
URL: https://github.com/apache/beam/pull/14278#discussion_r597938805



##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -505,6 +505,9 @@ def __init__(self, options, proto_pipeline):
           self.proto.transformNameMapping.additionalProperties.append(
               dataflow.Job.TransformNameMappingValue.AdditionalProperty(
                   key=key, value=value))
+    if self.google_cloud_options.create_from_snapshot:

Review comment:
       What is the option name in other SDKs? There is a minor mismatch between `createdFromSnapshotId` and `create_from_snapshot`. Is id relevant here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org