You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/27 11:38:44 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #17153: Fix the scaling error with increment task not handled unsign type correctly
azexcy opened a new pull request, #17153:
URL: https://github.com/apache/shardingsphere/pull/17153
Fix the scaling error with increment task not handled unsign type correctly
Fixes #17077.
Changes proposed in this pull request:
- Check whether the value is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #17153: Fix the scaling error with increment task not handled unsign type correctly
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #17153:
URL: https://github.com/apache/shardingsphere/pull/17153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #17153: Fix the scaling error with increment task not handled unsign type correctly
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #17153:
URL: https://github.com/apache/shardingsphere/pull/17153#discussion_r859691601
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/column/value/impl/MySQLUnsignedBigintHandler.java:
##########
@@ -31,6 +31,9 @@ public final class MySQLUnsignedBigintHandler implements MySQLDataTypeHandler {
@Override
public Serializable handle(final Serializable value) {
+ if (value == null) {
+ return null;
+ }
Review Comment:
It could be `null == value`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org