You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/18 10:01:23 UTC

[GitHub] [spark] yaooqinn commented on a change in pull request #31227: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

yaooqinn commented on a change in pull request #31227:
URL: https://github.com/apache/spark/pull/31227#discussion_r559446032



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -761,8 +761,9 @@ class SparkContext(config: SparkConf) extends Logging {
    */
   def setJobGroup(groupId: String,
       description: String, interruptOnCancel: Boolean = false): Unit = {
+    val actualGroupId = getJobGroupId(groupId)

Review comment:
       https://github.com/apache/spark/pull/31227/files#diff-1e596e9e9bd50e3075847a66f8fecee741289b2b0478f9099c3bf2b680ebaa35R749-R755
   
   This looks like a silent API behavior change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org