[GitHub] [calcite] danny0405 commented on a change in pull request #1543: [Calcite-3455] Redundant rule firing for both logical and physical nodes

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1543: [Calcite-3455] Redundant rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r339870118
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/ProjectMergeRule.java
 ##########
 @@ -54,8 +55,8 @@
    */
   public ProjectMergeRule(boolean force, RelBuilderFactory relBuilderFactory) {
     super(
-        operand(Project.class,
-            operand(Project.class, any())),
+        operand(LogicalProject.class,
+            operand(LogicalProject.class, any())),
 
 Review comment:
   The changes sounds reasonable to me, but i'm a little worried about the compatibility. It would give us more confidence if some engine like Druid can give feedback that this change does not break something

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services