You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/30 06:14:16 UTC
[GitHub] [superset] hughhhh opened a new pull request, #22269: [DONT MERGE] TEST SSH TUNNEL
hughhhh opened a new pull request, #22269:
URL: https://github.com/apache/superset/pull/22269
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh closed pull request #22269: [DONT MERGE] TEST SSH TUNNEL
Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #22269: [DONT MERGE] TEST SSH TUNNEL
URL: https://github.com/apache/superset/pull/22269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22269: [DONT MERGE] TEST SSH TUNNEL
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22269:
URL: https://github.com/apache/superset/pull/22269#issuecomment-1331695041
# [Codecov](https://codecov.io/gh/apache/superset/pull/22269?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22269](https://codecov.io/gh/apache/superset/pull/22269?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c59663) into [master](https://codecov.io/gh/apache/superset/commit/a77b2d6ebfbe8caf98b2c0d00a19f3f744f18b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a77b2d6) will **increase** coverage by `1.25%`.
> The diff coverage is `83.43%`.
```diff
@@ Coverage Diff @@
## master #22269 +/- ##
==========================================
+ Coverage 65.49% 66.75% +1.25%
==========================================
Files 1835 1841 +6
Lines 69927 70606 +679
Branches 7590 7590
==========================================
+ Hits 45802 47136 +1334
+ Misses 22159 21504 -655
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <59.74%> (?)` | |
| javascript | `53.80% <ø> (ø)` | |
| mysql | `78.05% <64.93%> (-0.04%)` | :arrow_down: |
| postgres | `78.11% <64.93%> (-0.04%)` | :arrow_down: |
| presto | `52.48% <59.74%> (?)` | |
| python | `80.62% <83.43%> (+2.35%)` | :arrow_up: |
| sqlite | `76.57% <64.93%> (-0.03%)` | :arrow_down: |
| unit | `50.84% <82.20%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.27% <45.45%> (-2.01%)` | :arrow_down: |
| [superset/databases/ssh\_tunnel/models.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvbW9kZWxzLnB5) | `76.66% <76.66%> (ø)` | |
| [superset/databases/ssh\_tunnel/commands/delete.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvY29tbWFuZHMvZGVsZXRlLnB5) | `87.50% <87.50%> (ø)` | |
| [superset/databases/ssh\_tunnel/commands/update.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvY29tbWFuZHMvdXBkYXRlLnB5) | `88.46% <88.46%> (ø)` | |
| [superset/databases/ssh\_tunnel/commands/create.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvY29tbWFuZHMvY3JlYXRlLnB5) | `91.30% <91.30%> (ø)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.68% <100.00%> (+0.01%)` | :arrow_up: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `98.34% <100.00%> (+3.50%)` | :arrow_up: |
| [...perset/databases/ssh\_tunnel/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/databases/ssh\_tunnel/dao.py](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NzaF90dW5uZWwvZGFvLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [71 more](https://codecov.io/gh/apache/superset/pull/22269/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org