You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2024/04/10 15:24:02 UTC

[PR] ORC-1686: [C++] Avoid using std::filesystem [orc]

wgtmac opened a new pull request, #1886:
URL: https://github.com/apache/orc/pull/1886

   ### What changes were proposed in this pull request?
   Remove std::filesystem and use OS API instead.
   
   ### Why are the changes needed?
   Apache Arrow C++ library is required to support old compilers like clang8. Since Apache ORC C++ library has used std::filesystem to check TZDB availability since 2.0.0, Apache Arrow requires to add more linking options for std::filesystem. See https://github.com/apache/arrow/pull/41023 for detail.
   
   ### How was this patch tested?
   Passing CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1686: [C++] Avoid using std::filesystem [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1886: ORC-1686: [C++] Avoid using std::filesystem
URL: https://github.com/apache/orc/pull/1886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1686: [C++] Avoid using std::filesystem [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1886:
URL: https://github.com/apache/orc/pull/1886#issuecomment-2048119158

   I added `2.0.1` as the milestone. Thank you for doing this follow-up, @wgtmac .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1686: [C++] Avoid using std::filesystem [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1886:
URL: https://github.com/apache/orc/pull/1886#issuecomment-2048137262

   Merged to main/2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1686: [C++] Avoid using std::filesystem [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1886:
URL: https://github.com/apache/orc/pull/1886#issuecomment-2048732374

   Thanks @dongjoon-hyun! Yes, it should be ported to 2.0.1 as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org