You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2016/12/20 12:20:42 UTC

Review Request 54891: Create quick links profile evaluator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
-----------------------------------------------------------

Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-19244
    https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
-------

Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
-------

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
  AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage

Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31


Thanks,

Bal�zs Bence S�ri


Re: Review Request 54891: Create quick links profile evaluator

Posted by Balázs Bence Sári <bs...@hortonworks.com>.

> On Dec. 20, 2016, 2:49 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java, line 149
> > <https://reviews.apache.org/r/54891/diff/1/?file=1589499#file1589499line149>
> >
> >     `Link.getProperties()` is `@Nullable`.

Good catch!


> On Dec. 20, 2016, 2:49 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java, line 4
> > <https://reviews.apache.org/r/54891/diff/1/?file=1589500#file1589500line4>
> >
> >     Wouldn't `IllegalArgumentException` be OK for the same purpose?

In this case I wanted a checked exception.


- Bal�zs Bence


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review159704
-----------------------------------------------------------


On Dec. 20, 2016, 12:20 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 12:20 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>


Re: Review Request 54891: Create quick links profile evaluator

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review159704
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (lines 40 - 42)
<https://reviews.apache.org/r/54891/#comment230748>

    Could be `final`.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (lines 63 - 64)
<https://reviews.apache.org/r/54891/#comment230728>

    Please enclose in {}



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (lines 68 - 69)
<https://reviews.apache.org/r/54891/#comment230729>

    Please enclose in {}



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (line 81)
<https://reviews.apache.org/r/54891/#comment230731>

    ServiceComponent is created 2x (line 77, line 81).



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (lines 101 - 103)
<https://reviews.apache.org/r/54891/#comment230736>

    Could be final.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (line 149)
<https://reviews.apache.org/r/54891/#comment230754>

    `Link.getProperties()` is `@Nullable`.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (line 150)
<https://reviews.apache.org/r/54891/#comment230753>

    Could be simplified with `CollectionUtils.containsAny`.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java (line 1)
<https://reviews.apache.org/r/54891/#comment230724>

    Missing license.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java (line 4)
<https://reviews.apache.org/r/54891/#comment230749>

    Wouldn't `IllegalArgumentException` be OK for the same purpose?



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (line 31)
<https://reviews.apache.org/r/54891/#comment230757>

    Please move to `com.google` block of imports.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (lines 40 - 44)
<https://reviews.apache.org/r/54891/#comment230741>

    Could be `private`.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (line 46)
<https://reviews.apache.org/r/54891/#comment230756>

    Could be `final`.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (line 57)
<https://reviews.apache.org/r/54891/#comment230738>

    Please do not add `@throws Exception` javadoc, does not add any value.  (Also in other test methods and in QuickLinksProfileEvaluatorTest.)



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (line 77)
<https://reviews.apache.org/r/54891/#comment230725>

    Trailing whitespace.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java (line 150)
<https://reviews.apache.org/r/54891/#comment230755>

    Unused local variable (also in following two methods).



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java (lines 33 - 37)
<https://reviews.apache.org/r/54891/#comment230742>

    Could be `private`.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java (line 40)
<https://reviews.apache.org/r/54891/#comment230744>

    Could be `final`.


- Attila Doroszlai


On Dec. 20, 2016, 1:20 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 1:20 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>


Re: Review Request 54891: Create quick links profile evaluator

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160044
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Dec. 21, 2016, 8 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 8 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 0644027 
>   ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_common_services/HIVE/0.11.0.2.0.5.0/package/.hash 9550dab 
>   ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash 9550dab 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>


Re: Review Request 54891: Create quick links profile evaluator

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160100
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Dec. 23, 2016, 8:54 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 8:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 5f93475 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>


Re: Review Request 54891: Create quick links profile evaluator

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160101
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 23, 2016, 8:59 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 8:59 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 5f93475 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>


Re: Review Request 54891: Create quick links profile evaluator

Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
-----------------------------------------------------------

(Updated Dec. 23, 2016, 7:59 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-19244
    https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
-------

Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 5f93475 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
  ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
-------

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
  AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage

Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31


Thanks,

Bal�zs Bence S�ri


Re: Review Request 54891: Create quick links profile evaluator

Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
-----------------------------------------------------------

(Updated Dec. 23, 2016, 7:54 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

Fixed import order, deleted .hash file


Bugs: AMBARI-19244
    https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
-------

Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 5f93475 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
  ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
-------

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
  AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage

Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31


Thanks,

Bal�zs Bence S�ri


Re: Review Request 54891: Create quick links profile evaluator

Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
-----------------------------------------------------------

(Updated Dec. 21, 2016, 7 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

Fixed rename related issues.


Bugs: AMBARI-19244
    https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
-------

Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 0644027 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_common_services/HIVE/0.11.0.2.0.5.0/package/.hash 9550dab 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash 9550dab 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
  ambari-server/src/test/resources/parent_quicklinks_with_properties.json a315f3f 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
-------

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
  AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage

Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31


Thanks,

Bal�zs Bence S�ri


Re: Review Request 54891: Create quick links profile evaluator

Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
-----------------------------------------------------------

(Updated Dec. 21, 2016, 6:43 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

Fixed review comments + renamed link properties to attributes on Sumit's request, removed unused import


Bugs: AMBARI-19244
    https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
-------

Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 72ad764 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java 5124241 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java 1711628 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java 7b5eba0 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java c1f3c86 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java 190e61b 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 0644027 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_common_services/HIVE/0.11.0.2.0.5.0/package/.hash 9550dab 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash 9550dab 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
-------

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
  AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage

Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31


Thanks,

Bal�zs Bence S�ri


Re: Review Request 54891: Create quick links profile evaluator

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review159731
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java (line 100)
<https://reviews.apache.org/r/54891/#comment230764>

    Document here the precedence in which filters are applied. Currently the expected behavior can be derived from the unit tests but I think it's convenient to have documented here as well.


- Sebastian Toader


On Dec. 20, 2016, 1:20 p.m., Bal�zs Bence S�ri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 1:20 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
>     https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Profile evaluator is a class that takes a quick links profile as input and can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java 7ef0259 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java 1a1488b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 600872f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> -------
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected:<class DS_DataStoreImplTest$TestEntity_1> but was:<class DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed �  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 � ClassCast class sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 � Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Bal�zs Bence S�ri
> 
>