You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/09 22:27:32 UTC

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #655: HDDS-3100. Fix TestDeadNodeHandler.

avijayanhwx opened a new pull request #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655
 
 
   ## What changes were proposed in this pull request?
   
   Fix issue in TestNodeHandler which was caused due to the race condition between the 3 Factor pipeline creation in SCM, and the explicit opening of all pipelines in the Test.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3100
   
   ## How was this patch tested?
   Ran the test a few times in the IDE and command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655#issuecomment-597208683
 
 
   > Unit test failure (TestBlockManager) is unrelated.
   
   Being fixed in HDDS-2989.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655#issuecomment-597429367
 
 
   Thank You @avijayanhwx for the contribution and @adoroszlai for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655#issuecomment-597303328
 
 
   Thank you for the review @adoroszlai. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655#discussion_r390547825
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestDeadNodeHandler.java
 ##########
 @@ -89,16 +89,16 @@ public void setup() throws IOException, AuthenticationException {
     storageDir = GenericTestUtils.getTempPath(
         TestDeadNodeHandler.class.getSimpleName() + UUID.randomUUID());
     conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, storageDir);
-    conf.setInt(OZONE_DATANODE_PIPELINE_LIMIT, 0);
     eventQueue = new EventQueue();
+    System.out.println("eventQueue = "  + eventQueue.toString());
 
 Review comment:
   Leftover debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #655: HDDS-3100. Fix TestDeadNodeHandler.
URL: https://github.com/apache/hadoop-ozone/pull/655#issuecomment-597207559
 
 
   Unit test failure (TestBlockManager) is unrelated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org