You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2007/05/22 17:56:16 UTC
[jira] Created: (HADOOP-1414) Findbugs - Bad Practice
Findbugs - Bad Practice
-----------------------
Key: HADOOP-1414
URL: https://issues.apache.org/jira/browse/HADOOP-1414
Project: Hadoop
Issue Type: Bug
Reporter: dhruba borthakur
Assigned To: dhruba borthakur
Fix For: 0.14.0
Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: (was: findbugs_badpractice2.patch)
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: findbugs_badpractice.patch
This patch fixes most of the cases that were detected by findbugs in the "bad Practice" category. The ones that are not fixed are of the following type:
1. Comparator does not implement Serializable.
2. Ignores IOException
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Status: Open (was: Patch Available)
This is a patch to fix findbugs warnings and "findbugs" reports that there is one new warning introduced by this patch! Got to fix it.
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: findbugs_badpractice2.patch
Used readFully() instead of hand-coding loops around InputStream.read().
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1414) Findbugs - Bad Practice
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499747 ]
Hadoop QA commented on HADOOP-1414:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12358404/findbugs_badpractice3.patch applied and successfully tested against trunk revision r541792.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/208/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/208/console
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice3.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1414) Findbugs - Bad Practice
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499256 ]
Hadoop QA commented on HADOOP-1414:
-----------------------------------
+0, new Findbugs warnings
http://issues.apache.org/jira/secure/attachment/12358285/findbugs_badpractice2.patch
applied and successfully tested against trunk revision r541792,
but there appear to be new Findbugs warnings introduced by this patch.
New Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/206/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/206/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/206/console
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Status: Patch Available (was: Open)
Fixed most cases detected by FindBugs in the BadPractice category. (There are a few remaining in the SequenceFiles*).
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: (was: findbugs_badpractice2.patch)
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: (was: findbugs_badpractice.patch)
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Status: Patch Available (was: Open)
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice3.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-1414:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Dhruba!
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice3.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1414) Findbugs - Bad Practice
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503917 ]
Hadoop QA commented on HADOOP-1414:
-----------------------------------
Integrated in Hadoop-Nightly #119 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/119/])
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice3.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: findbugs_badpractice2.patch
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice2.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1414) Findbugs - Bad Practice
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-1414:
-------------------------------------
Attachment: findbugs_badpractice3.patch
Introduced a hashCode() method to SequenceFile.SegmentDescriptor class.
> Findbugs - Bad Practice
> -----------------------
>
> Key: HADOOP-1414
> URL: https://issues.apache.org/jira/browse/HADOOP-1414
> Project: Hadoop
> Issue Type: Bug
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.14.0
>
> Attachments: findbugs_badpractice3.patch
>
>
> Fix most issues categorized as "Bad Practice" by the findbugs tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.