You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "simonatoaca (via GitHub)" <gi...@apache.org> on 2023/07/04 09:00:51 UTC
[GitHub] [nuttx] simonatoaca opened a new pull request, #9694: Modified rgb led pwm freq from 100 to 200
simonatoaca opened a new pull request, #9694:
URL: https://github.com/apache/nuttx/pull/9694
## Summary
I am currently trying to add the RGB driver to an esp32 based board. The LED on the board did not function correctly at the old frequency (that was hard-coded in the driver), 200 being more suitable. The RGB driver support is already added to stm32,
and I **suppose** 100 was right for that situation, so simply modifying the frequency inside the driver might make it unusable for stm32 or other boards with the driver already implemented. The question is: Is 200 appropriate for any led or is custom configuring necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9694: Modified rgb led pwm freq from 100 to 200
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9694:
URL: https://github.com/apache/nuttx/pull/9694#issuecomment-1620212254
Thank you @simonatoaca
Please consider submitting later an esp32/common board support to this RGB LED :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9694: Modified rgb led pwm freq from 100 to 200
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9694:
URL: https://github.com/apache/nuttx/pull/9694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #9694: Modified rgb led pwm freq from 100 to 200
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #9694:
URL: https://github.com/apache/nuttx/pull/9694#issuecomment-1619852300
A better option would be to make the frequency configurable with Kconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org