[jira] Commented: (WOOKIE-65) Refactored comet notifications with sibling-instance scope

["Scott Wilson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WOOKIE-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848913#action_12848913 ] 

Scott Wilson commented on WOOKIE-65:
------------------------------------

OK, I've applied the patch, and we can look at the extensions proposed by the students to see how they can (hopefully) build on the functionality here.

> Refactored comet notifications with sibling-instance scope
> ----------------------------------------------------------
>
>                 Key: WOOKIE-65
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-65
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Server
>            Reporter: Scott Wilson
>             Fix For: 0.8.2
>
>         Attachments: notifications_patch.txt, notifications_patch_2.txt
>
>
> I've created an refactored version of the Notifier helper that is less "scattergun" in its approach to propagating notifications to widget instances, using the DWR PageNormalizer interface.
> This does get rid of some code duplication and generally makes the notifier easier to extend.
> However, I haven't been able to really test this and see how it affects performance - while it generates fewer pushes to clients, each client request potentially triggers more activity, so its possible this could go either way.
> With that in mind I've attached a patch for review rather than committing these changes as I'd appreciate feedback before going ahead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.