[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15796: [enhancement](load) delete skiplist for duplicate table in memtable

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15796:
URL: https://github.com/apache/doris/pull/15796#discussion_r1066518076


##########
be/src/olap/memtable.cpp:
##########
@@ -281,21 +301,20 @@ void MemTable::_collect_vskiplist_results() {
                     vectorized::MutableBlock::build_mutable_block(empty_input_block.get());
             _output_mutable_block.clear_column_data();
         }
-    }
 
-    if (is_final) {
-        _vec_skip_list.reset();
+        if (is_final) {
+            _vec_skip_list.reset();
+        }
     }
 }
 
 void MemTable::shrink_memtable_by_agg() {
     SCOPED_CONSUME_MEM_TRACKER(_insert_mem_tracker_use_hook.get());
-    if (_keys_type == KeysType::DUP_KEYS) {
-        return;
-    }
-    _collect_vskiplist_results<false>();
+    DCHECK(_keys_type == KeysType::AGG_KEYS);
+    _collect_memtable_results<false>();
 }
 
+bool MemTable::need_flush() const {
 bool MemTable::need_flush() const {

Review Comment:
   warning: function definition is not allowed here [clang-diagnostic-error]
   ```cpp
   bool MemTable::need_flush() const {
                                     ^
   ```
   



##########
be/src/olap/memtable.cpp:
##########
@@ -357,7 +376,7 @@
 
 Status MemTable::_do_flush(int64_t& duration_ns) {

Review Comment:
   warning: function definition is not allowed here [clang-diagnostic-error]
   ```cpp
   Status MemTable::_do_flush(int64_t& duration_ns) {
                                                    ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org