You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/17 07:18:55 UTC
[GitHub] [shardingsphere] Jacob953 opened a new pull request, #22232: Move all legacy version documents to a new legacy page
Jacob953 opened a new pull request, #22232:
URL: https://github.com/apache/shardingsphere/pull/22232
Fixes #19382.
Changes proposed in this pull request:
- Refactor legacy page to hugo theme.
- Range legacy versions for summary.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Jacob953 commented on pull request #22232: Move all legacy version documents to a new legacy page
Posted by GitBox <gi...@apache.org>.
Jacob953 commented on PR #22232:
URL: https://github.com/apache/shardingsphere/pull/22232#issuecomment-1318269705
I'll show you other details below.
<img width="1440" alt="image" src="https://user-images.githubusercontent.com/64075563/202394381-fe737403-6809-4537-9ba2-9d1bcaeecf4d.png">
<img width="1440" alt="image" src="https://user-images.githubusercontent.com/64075563/202394422-0b1c6d4a-c085-4dc2-ac80-fca67df604e3.png">
Click `View` of 4.1.1
<img width="443" alt="image" src="https://user-images.githubusercontent.com/64075563/202395617-5246516a-faf9-4cb7-ad97-d7e588ddfa11.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Jacob953 commented on pull request #22232: Move all legacy version documents to a new legacy page
Posted by GitBox <gi...@apache.org>.
Jacob953 commented on PR #22232:
URL: https://github.com/apache/shardingsphere/pull/22232#issuecomment-1318668342
Steps:
1. Read different documents of versions from `content`
```
{{ $versions := slice }}
{{ range os.ReadDir "content" }}
{{ $versions = $versions | append .Name }}
{{ end }}
```
<img width="230" alt="image" src="https://user-images.githubusercontent.com/64075563/202462553-6d6f487f-5a8a-4ea7-b067-dd05ec23867c.png">
2. Reverse the slice to make sure the newer one is close to the top
```
{{ $versions = partial "reverse.html" $versions -}}
```
3. Range all legacy versions to list them.
<img width="423" alt="image" src="https://user-images.githubusercontent.com/64075563/202463509-6042c75b-7164-4a72-8328-d35edcf137f4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Jacob953 commented on pull request #22232: Move all legacy version documents to a new legacy page
Posted by GitBox <gi...@apache.org>.
Jacob953 commented on PR #22232:
URL: https://github.com/apache/shardingsphere/pull/22232#issuecomment-1318199322
Effect
<img width="1419" alt="image" src="https://user-images.githubusercontent.com/64075563/202381842-08a982a3-b32b-4110-8e39-b43542337e32.png">
<img width="1408" alt="image" src="https://user-images.githubusercontent.com/64075563/202381882-efe6b525-11d3-46da-94ea-6ef1da46c35f.png">
<img width="650" alt="image" src="https://user-images.githubusercontent.com/64075563/202382051-63b82d06-1a9e-4511-bdea-40c343fae505.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Jacob953 commented on pull request #22232: Move all legacy version documents to a new legacy page
Posted by GitBox <gi...@apache.org>.
Jacob953 commented on PR #22232:
URL: https://github.com/apache/shardingsphere/pull/22232#issuecomment-1318258380
I just removed the `content` directory, since it was too large to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Jacob953 closed pull request #22232: Move all legacy version documents to a new legacy page
Posted by GitBox <gi...@apache.org>.
Jacob953 closed pull request #22232: Move all legacy version documents to a new legacy page
URL: https://github.com/apache/shardingsphere/pull/22232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org