[GitHub] ascrutae commented on a change in pull request #950: [Agent] Provide plugin for Tomcat 6.x

[GitBox <gi...@apache.org>]

ascrutae commented on a change in pull request #950: [Agent] Provide plugin for Tomcat 6.x
URL: https://github.com/apache/incubator-skywalking/pull/950#discussion_r174985367
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/tomcat-7.x-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat78x/define/TomcatInstrumentation.java
 ##########
 @@ -93,4 +93,13 @@ public boolean isOverrideArgs() {
             }
         };
     }
+    @Override
+    protected String[] witnessClasses() {
+        /**
+         * @see <code>javax.servlet.annotation.HandlesTypes<code/>
+         */
+        return new String[] {
+            "javax.servlet.annotation.HandlesTypes"
 
 Review comment:
   Can you sure that tomcat 6 can't run with servlet 3.x ? because the `javax.servlet.annotation.HandlesTypes` class is in `javax.servlet-3.0.jar`. I am not sure that it is works

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services