[GitHub] vrozov commented on a change in pull request #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata

[GitBox <gi...@apache.org>]

vrozov commented on a change in pull request #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata
URL: https://github.com/apache/drill/pull/1367#discussion_r201159333
 
 

 ##########
 File path: exec/vector/src/main/codegen/templates/BasicTypeHelper.java
 ##########
 @@ -233,10 +227,54 @@ public static ValueVector getNewVector(String name, BufferAllocator allocator, M
       throw new UnsupportedOperationException(buildErrorMessage("get holder reader implementation", type, mode));
   }
   
-  public static ValueVector getNewVector(MaterializedField field, BufferAllocator allocator){
+  public static ValueVector getNewVector(String name, BufferAllocator allocator, MajorType type, CallBack callBack) {
+    MaterializedField field = MaterializedField.create(name, type);
+    return getNewVector(field, allocator, callBack);
+  }  
+  
+  public static ValueVector getNewVector(MaterializedField field, BufferAllocator allocator) {
 
 Review comment:
   `getNewVector(MaterializedField field, ...` promotes `field` sharing between vectors and possibly threads. What are the use cases where `MaterializedField` needs to be shared between vectors? I mean, when is it necessary that modifications to `MaterializedField` that belongs to one vector are reflected transparently in another vector `MaterializedField`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services