You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by GitBox <gi...@apache.org> on 2022/02/25 17:23:26 UTC
[GitHub] [ws-wss4j] rsearls opened a new pull request #45: Migrated to native jakarta
rsearls opened a new pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45
Import changes to reference jakarta name space.
Referencing org.apache.santuario:xmlsec:2.3.1-SNAPSHOT because no final version is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r819073760
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,29 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.xml.soap-api.version>2.0.1</jakarta.xml.soap-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
</properties>
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>com.sun.mail</groupId>
+ <artifactId>jakarta.mail</artifactId>
+ <version>${jakarta.mail.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <version>${jakarta.xml.bind-api.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <version>${jakarta.xml.soap-api.version}</version>
+ </dependency>
Review comment:
org.glassfish.jaxb:jaxb-runtime can not be removed from ws-security-stax/pom.xml
it is required for KerberosTest.java to run successfully.
All other changes are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r818856519
##########
File path: ws-security-stax/pom.xml
##########
@@ -103,6 +107,15 @@
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.jaxb</groupId>
+ <artifactId>jaxb-runtime</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <scope>test</scope>
+ </dependency>
Review comment:
I think this can be removed
##########
File path: ws-security-stax/pom.xml
##########
@@ -35,6 +35,10 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ </dependency>
Review comment:
Remove
##########
File path: ws-security-policy-stax/pom.xml
##########
@@ -34,6 +34,11 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <scope>test</scope>
+ </dependency>
Review comment:
Remove
##########
File path: ws-security-common/pom.xml
##########
@@ -91,6 +91,10 @@
</build>
<dependencies>
+ <dependency>
+ <groupId>com.sun.mail</groupId>
+ <artifactId>jakarta.mail</artifactId>
Review comment:
Add compile scope
##########
File path: integration/pom.xml
##########
@@ -45,6 +45,11 @@
</build>
<dependencies>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <scope>test</scope>
+ </dependency>
Review comment:
Remove
##########
File path: ws-security-common/pom.xml
##########
@@ -242,6 +246,11 @@
<artifactId>hamcrest-library</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <scope>compile</scope>
+ </dependency>
Review comment:
Remove
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,29 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.xml.soap-api.version>2.0.1</jakarta.xml.soap-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
</properties>
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>com.sun.mail</groupId>
+ <artifactId>jakarta.mail</artifactId>
+ <version>${jakarta.mail.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <version>${jakarta.xml.bind-api.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <version>${jakarta.xml.soap-api.version}</version>
+ </dependency>
Review comment:
Remove
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,29 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.xml.soap-api.version>2.0.1</jakarta.xml.soap-api.version>
Review comment:
Remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r817497144
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,24 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
Review comment:
There are a bunch of old JAXB dependencies in the root pom under the JDK9 profile that need to be removed:
<dependency>
<groupId>jakarta.xml.ws</groupId>
<artifactId>jakarta.xml.ws-api</artifactId>
<version>2.3.3</version>
</dependency>
<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<version>2.3.3</version>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>2.3.2</version>
<scope>test</scope>
</dependency>
Once these are removed, then you can remove the jakarta API from ws-security-stax etc., as it is added already as a compile time dependency in Santuario (I changed it this morning so you might need to reinstall it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r820663496
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,29 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.xml.soap-api.version>2.0.1</jakarta.xml.soap-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
</properties>
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>com.sun.mail</groupId>
+ <artifactId>jakarta.mail</artifactId>
+ <version>${jakarta.mail.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <version>${jakarta.xml.bind-api.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <version>${jakarta.xml.soap-api.version}</version>
+ </dependency>
Review comment:
Change complete.
Created https://issues.apache.org/jira/browse/WSS-694 Move wss4j to native jakarta namespace. Added it to the PR commit msg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r816517874
##########
File path: ws-security-stax/pom.xml
##########
@@ -103,6 +107,10 @@
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
+ <artifactId>jaxb-impl</artifactId>
Review comment:
Could we change all instances of this dependency to:
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r816805385
##########
File path: ws-security-stax/pom.xml
##########
@@ -103,6 +107,10 @@
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
+ <artifactId>jaxb-impl</artifactId>
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea merged pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea merged pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1062904367
Sorry I did not see that field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r816013558
##########
File path: parent/pom.xml
##########
@@ -47,7 +47,7 @@
<wsdl4j.version>1.6.3</wsdl4j.version>
<xalan.version>2.7.2</xalan.version>
<xz.version>1.9</xz.version>
- <xmlsec.version>2.3.0</xmlsec.version>
+ <xmlsec.version>2.3.1-SNAPSHOT</xmlsec.version>
Review comment:
Requested change made.
Test failures resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r818685564
##########
File path: pom.xml
##########
@@ -394,22 +394,6 @@
</pluginManagement>
</build>
<dependencies>
- <dependency>
- <groupId>jakarta.xml.ws</groupId>
- <artifactId>jakarta.xml.ws-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.jaxb</groupId>
- <artifactId>jaxb-runtime</artifactId>
- <version>2.3.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>com.sun.xml.messaging.saaj</groupId>
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1062791101
Did you make a note to inform the webservices project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r818455212
##########
File path: pom.xml
##########
@@ -394,22 +394,6 @@
</pluginManagement>
</build>
<dependencies>
- <dependency>
- <groupId>jakarta.xml.ws</groupId>
- <artifactId>jakarta.xml.ws-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.jaxb</groupId>
- <artifactId>jaxb-runtime</artifactId>
- <version>2.3.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>com.sun.xml.messaging.saaj</groupId>
Review comment:
This (saaj) needs to be updated to 2.0.1 and some compile time dependencies fixed:
[ERROR] /Users/coheigea/src/apache/ws-wss4j/ws-security-common/src/test/java/org/apache/wss4j/common/util/SOAPUtil.java:[24,22] package javax.xml.soap does not exist
[ERROR] /Users/coheigea/src/apache/ws-wss4j/ws-security-common/src/test/java/org/apache/wss4j/common/util/SOAPUtil.java:[45,20] cannot find symbol
symbol: class MessageFactory
location: class org.apache.wss4j.common.util.SOAPUtil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r815688172
##########
File path: parent/pom.xml
##########
@@ -47,7 +47,7 @@
<wsdl4j.version>1.6.3</wsdl4j.version>
<xalan.version>2.7.2</xalan.version>
<xz.version>1.9</xz.version>
- <xmlsec.version>2.3.0</xmlsec.version>
+ <xmlsec.version>2.3.1-SNAPSHOT</xmlsec.version>
Review comment:
Change to 3.0.0-SNAPSHOT after applying https://github.com/apache/santuario-xml-security-java/pull/63
I see some errors:
java.lang.ExceptionInInitializerError
at org.apache.wss4j.stax.test.VulnerabliltyVectorsDecompressedBytesTest.setup(VulnerabliltyVectorsDecompressedBytesTest.java:44)
Caused by: java.lang.RuntimeException: Implementation of Jakarta XML Binding-API has not been found on module path or classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r817761848
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,24 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1062879778
Yes, here is the jira
https://issues.apache.org/jira/browse/WSS-694 Move wss4j to native jakarta namespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r818455212
##########
File path: pom.xml
##########
@@ -394,22 +394,6 @@
</pluginManagement>
</build>
<dependencies>
- <dependency>
- <groupId>jakarta.xml.ws</groupId>
- <artifactId>jakarta.xml.ws-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- <version>2.3.3</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.jaxb</groupId>
- <artifactId>jaxb-runtime</artifactId>
- <version>2.3.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>com.sun.xml.messaging.saaj</groupId>
Review comment:
This needs to be updated to 2.0.1 and some compile time dependencies fixed:
[ERROR] /Users/coheigea/src/apache/ws-wss4j/ws-security-common/src/test/java/org/apache/wss4j/common/util/SOAPUtil.java:[24,22] package javax.xml.soap does not exist
[ERROR] /Users/coheigea/src/apache/ws-wss4j/ws-security-common/src/test/java/org/apache/wss4j/common/util/SOAPUtil.java:[45,20] cannot find symbol
symbol: class MessageFactory
location: class org.apache.wss4j.common.util.SOAPUtil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1061750054
emailed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] rsearls commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
rsearls commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1062881596
Which webservices project are you thinking of?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#issuecomment-1062886027
There is a "Notify Project" field in https://www.apache.org/licenses/icla.pdf, I was wondering if you added in WebServices (WSS4J parent project), to inform us. Otherwise I will try to find out directly if it was received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on a change in pull request #45: Migrated to native jakarta
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r820461115
##########
File path: parent/pom.xml
##########
@@ -56,10 +56,29 @@
<wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
<wss4j.osgi.dynamic.import />
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+ <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+ <jakarta.xml.soap-api.version>2.0.1</jakarta.xml.soap-api.version>
+ <jakarta.mail.version>2.0.0</jakarta.mail.version>
+ <jaxb-runtime.version>3.0.2</jaxb-runtime.version>
</properties>
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>com.sun.mail</groupId>
+ <artifactId>jakarta.mail</artifactId>
+ <version>${jakarta.mail.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <version>${jakarta.xml.bind-api.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.xml.soap</groupId>
+ <artifactId>jakarta.xml.soap-api</artifactId>
+ <version>${jakarta.xml.soap-api.version}</version>
+ </dependency>
Review comment:
Could it be changed to runtime scope instead? and finally, can you create a WSS JIRA for this change and reference the JIRA number in the commit message? Then we should be good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org