You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/24 12:57:23 UTC

[GitHub] [incubator-hugegraph] seagle-yuan opened a new pull request, #1846: fix checkstyle IdHolder issue

seagle-yuan opened a new pull request, #1846:
URL: https://github.com/apache/incubator-hugegraph/pull/1846

   delete extra semicolons


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] imbajin merged pull request #1846: fix checkstyle IdHolder&AuthManager issue

Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1846:
URL: https://github.com/apache/incubator-hugegraph/pull/1846


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1846: fix checkstyle IdHolder&AuthManager issue

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1846:
URL: https://github.com/apache/incubator-hugegraph/pull/1846#issuecomment-1109222863

   It seems like the probability of failure is hign
   ![3](https://user-images.githubusercontent.com/13429553/165205119-65b0fda9-15e7-42f3-871a-59eb19247765.JPG)
   
   ![1](https://user-images.githubusercontent.com/13429553/165205018-545ee1c4-1eb8-471d-aa66-4849753ef5d8.JPG)
   ![2](https://user-images.githubusercontent.com/13429553/165205023-4f30b635-209b-4a61-ad5b-3ee3c3f7df09.JPG)
   
   Error:  Failures: 
   Error:    EdgeApiTest>BaseApiTest.init:82->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>
   Error:    GremlinApiTest>BaseApiTest.init:82->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>
   Error:  com.baidu.hugegraph.api.IndexLabelApiTest.testDelete(com.baidu.hugegraph.api.IndexLabelApiTest)
   Error:    Run 1: IndexLabelApiTest.testDelete:149->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.exception.ExistedException","message":"The index label 'personByAge' has existed","cause":""} expected:<202> but was:<400>
   Error:    Run 2: IndexLabelApiTest>BaseApiTest.teardown:92->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1846: fix checkstyle IdHolder issue

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1846:
URL: https://github.com/apache/incubator-hugegraph/pull/1846#issuecomment-1107838357

   # [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1846](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5761e16) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/9a8259ef3f22abf9781513b823a9f1096152d494?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a8259e) will **decrease** coverage by `16.47%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #1846       +/-   ##
   =============================================
   - Coverage     66.93%   50.45%   -16.48%     
   - Complexity      444      659      +215     
   =============================================
     Files           446      446               
     Lines         37966    37966               
     Branches       5410     5410               
   =============================================
   - Hits          25413    19157     -6256     
   - Misses         9957    16520     +6563     
   + Partials       2596     2289      -307     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/com/baidu/hugegraph/backend/page/IdHolder.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvcGFnZS9JZEhvbGRlci5qYXZh) | `75.53% <100.00%> (-5.32%)` | :arrow_down: |
   | [...du/hugegraph/util/FixedWatchWindowRateLimiter.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvRml4ZWRXYXRjaFdpbmRvd1JhdGVMaW1pdGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...du/hugegraph/backend/store/mysql/MysqlMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLW15c3FsL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL215c3FsL015c3FsTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/backend/store/raft/RaftStoreClosure.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0U3RvcmVDbG9zdXJlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyCreateJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5Q3JlYXRlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5UmVtb3ZlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ugegraph/backend/store/memory/InMemoryMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvbWVtb3J5L0luTWVtb3J5TWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...egraph/backend/store/hbase/HbaseStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWhiYXNlL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL2hiYXNlL0hiYXNlU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../hugegraph/backend/store/raft/StoreSerializer.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9TdG9yZVNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-98.42%)` | :arrow_down: |
   | [...ava/com/baidu/hugegraph/analyzer/WordAnalyzer.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2FuYWx5emVyL1dvcmRBbmFseXplci5qYXZh) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
   | ... and [188 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a8259e...5761e16](https://codecov.io/gh/apache/incubator-hugegraph/pull/1846?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org