[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #14661: [numpy] Support zero-dim and zero-size tensors in MXNet

[GitBox <gi...@apache.org>]

yzhliu commented on a change in pull request #14661: [numpy] Support zero-dim and zero-size tensors in MXNet
URL: https://github.com/apache/incubator-mxnet/pull/14661#discussion_r275489242
 
 

 ##########
 File path: scala-package/native/src/main/native/org_apache_mxnet_native_c_api.cc
 ##########
 @@ -892,6 +892,119 @@ JNIEXPORT jint JNICALL Java_org_apache_mxnet_LibInfo_mxExecutorBackward
   return ret;
 }
 
+JNIEXPORT jint JNICALL Java_org_apache_mxnet_LibInfo_mxExecutorReshape
 
 Review comment:
   as discussed offline with @lanking520 , the code before and after `MXExecutorReshape` are for converting Java object to C++ object (e.g., string) and vice versa. Thus have to use jni to do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services