[GitHub] [hudi] xushiyan commented on a diff in pull request #8860: [HUDI-6314] Fix spark sql core flow

["xushiyan (via GitHub)" <gi...@apache.org>]

xushiyan commented on code in PR #8860:
URL: https://github.com/apache/hudi/pull/8860#discussion_r1225792935


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala:
##########
@@ -46,18 +47,18 @@ class TestSparkSqlCoreFlow extends HoodieSparkSqlTestBase {
         "COPY_ON_WRITE|false|false|org.apache.hudi.keygen.SimpleKeyGenerator|SIMPLE",
         "COPY_ON_WRITE|true|false|org.apache.hudi.keygen.SimpleKeyGenerator|SIMPLE",
         "COPY_ON_WRITE|true|true|org.apache.hudi.keygen.SimpleKeyGenerator|SIMPLE",
-        "COPY_ON_WRITE|false|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|GLOBAL_BLOOM",
-        "COPY_ON_WRITE|true|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|GLOBAL_BLOOM",
-        "COPY_ON_WRITE|true|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|GLOBAL_BLOOM",
+//        "COPY_ON_WRITE|false|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|GLOBAL_BLOOM",
+//        "COPY_ON_WRITE|true|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|GLOBAL_BLOOM",

Review Comment:
   The failure is caused by ExpressionPayload not working properly, the fix is a bit involved so tracking it separated in https://issues.apache.org/jira/browse/HUDI-6354. Meanwhile, these testcases should pass with a fix in [1fbc496](https://github.com/apache/hudi/pull/8860/commits/1fbc49655df663197d5bffcd107e0c865a35a953), which bypass the issue. will address the ExpressionPayload issue separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org