You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/08 16:26:57 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
slinkydeveloper opened a new pull request #17441:
URL: https://github.com/apache/flink/pull/17441
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR is part of the issue https://issues.apache.org/jira/browse/FLINK-21456 to unify the string conversion logic for the SQL data types. This PR changes the `PrintUtils` methods to make them accept only internal data types. In order to do that, several changes were required, in particular inside sql client which is mainly using external data types, but then relies heavily on `PrintUtils` for the print to screen logic. Next PRs will take care of cleaning up the logic of `PrintUtils`.
## Brief change log
- Introduce `TableResultInternal` to expose an iterator for internal types, and use it in return types of `TableEnvironmentInternal`
- Modified the collector sink in order to emit data using internal data types
- Support both internal and external types in `CollectResultProvider` (renamed to `ResultProvider`)
- Migrated most of the internal `Row` usages in common, api and sql client to `RowData`. No public API is affected.
## Verifying this change
This change is already covered by tests in table common and sql client.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
* f3d5c648bf84c4709dfc8baa512e5ba37b601873 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r731087036
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java
##########
@@ -437,10 +463,28 @@ private ResolvedSchema getSchema() {
RowKind.DELETE,
null,
-1,
- -1,
+ -1L,
"これは日本語をテストするための文です",
BigDecimal.valueOf(-12345.06789),
Timestamp.valueOf("2020-03-04 18:39:14")));
- return data;
+ return data.stream()
Review comment:
This requires importing table-runtime as test dependency of table-common, I think we should keep as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a10760f62b70db58a953e0d8e304bafa56a053e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958)
* 5a10760f62b70db58a953e0d8e304bafa56a053e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958)
* 5a10760f62b70db58a953e0d8e304bafa56a053e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727084553
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1462,7 +1478,17 @@ private TableResult buildDescribeResult(ResolvedSchema schema) {
return new String[] {"name", "type", "null", "key", "extras", "watermark"};
}
- private TableResult buildShowColumnsResult(
+ private static RowData generateTableColumnsDataTypesConverter(Row row) {
+ return GenericRowData.of(
Review comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a10760f62b70db58a953e0d8e304bafa56a053e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994)
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17441:
URL: https://github.com/apache/flink/pull/17441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727086466
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -124,17 +117,86 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
@Override
public DynamicTableSink copy() {
- final CollectDynamicSink copy =
- new CollectDynamicSink(
- tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
- // kind of violates the contract of copy() but should not harm
- // as it is null during optimization anyway until physical translation
- copy.iterator = iterator;
- return copy;
+ return new CollectDynamicSink(
+ tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
}
@Override
public String asSummaryString() {
return String.format("TableToCollect(type=%s)", consumedDataType);
}
+
+ private final class CollectResultProvider implements ResultProvider {
+
+ private CloseableRowIteratorWrapper<RowData> rowDataIterator;
+ private CloseableRowIteratorWrapper<Row> rowIterator;
+
+ private void initialize() {
+ if (this.rowIterator == null) {
+ this.rowDataIterator =
+ new CloseableRowIteratorWrapper<>(iterator, Function.identity());
+ this.rowIterator =
+ new CloseableRowIteratorWrapper<>(
+ iterator, r -> (Row) converter.toExternal(r));
+ }
+ }
+
+ @Override
+ public ResultProvider setJobClient(JobClient jobClient) {
+ iterator.setJobClient(jobClient);
+ return this;
+ }
+
+ @Override
+ public CloseableIterator<RowData> toInternalIterator() {
+ initialize();
+ return this.rowDataIterator;
+ }
+
+ @Override
+ public CloseableIterator<Row> toExternalIterator() {
+ initialize();
+ return this.rowIterator;
+ }
+
+ @Override
+ public boolean isFirstRowReady() {
+ initialize();
+ return this.rowDataIterator.firstRowProcessed
+ || this.rowIterator.firstRowProcessed
+ || iterator.hasNext();
+ }
+ }
+
+ private static final class CloseableRowIteratorWrapper<T> implements CloseableIterator<T> {
+ private final CloseableIterator<RowData> iterator;
+ private final Function<RowData, T> mapper;
Review comment:
In this particular case, I can't use `DataStructureConverter` because this class is used in two cases: for `Row` iteration (where I need to invoke the converter) and for `RowData` iteration (where I don't need any conversion, hence the function is the identity).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-942097735
This is ready for another pass. I also tested the sql client manually and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r731092407
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -115,6 +105,9 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
externalSerializer,
accumulatorName,
checkpointConfig);
+ this.converter = context.createDataStructureConverter(consumedDataType);
+ this.converter.open(
+ RuntimeConverter.Context.create(config.getClass().getClassLoader()));
Review comment:
Given this lambda runs in the same classloader of the table environment, i think using the current thread classloader just makes sense?
> I would call the open() later.
Do you have any specific location where you would call it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r731066521
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -115,6 +105,9 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
externalSerializer,
accumulatorName,
checkpointConfig);
+ this.converter = context.createDataStructureConverter(consumedDataType);
+ this.converter.open(
+ RuntimeConverter.Context.create(config.getClass().getClassLoader()));
Review comment:
ideally, the classloader of the session (table environment) is used here. currently, we don't have a central way of declaring the classloader in `EnvironmentSettings` when initializing the environment but this might happen soon. for now, we should use `Thread.currentThread().getContextClassloader()`. But we should prepare the stack already to pass the classloader from table environment to this location? If this is too complicated here, I would call the `open()` later.
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java
##########
@@ -437,10 +463,28 @@ private ResolvedSchema getSchema() {
RowKind.DELETE,
null,
-1,
- -1,
+ -1L,
"これは日本語をテストするための文です",
BigDecimal.valueOf(-12345.06789),
Timestamp.valueOf("2020-03-04 18:39:14")));
- return data;
+ return data.stream()
Review comment:
use also `DataStructureConverter` here, similar to the other test with addressed feedback
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -124,17 +117,86 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
@Override
public DynamicTableSink copy() {
- final CollectDynamicSink copy =
- new CollectDynamicSink(
- tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
- // kind of violates the contract of copy() but should not harm
- // as it is null during optimization anyway until physical translation
- copy.iterator = iterator;
- return copy;
+ return new CollectDynamicSink(
+ tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
}
@Override
public String asSummaryString() {
return String.format("TableToCollect(type=%s)", consumedDataType);
}
+
+ private final class CollectResultProvider implements ResultProvider {
+
+ private CloseableRowIteratorWrapper<RowData> rowDataIterator;
+ private CloseableRowIteratorWrapper<Row> rowIterator;
+
+ private void initialize() {
+ if (this.rowIterator == null) {
+ this.rowDataIterator =
+ new CloseableRowIteratorWrapper<>(iterator, Function.identity());
+ this.rowIterator =
+ new CloseableRowIteratorWrapper<>(
+ iterator, r -> (Row) converter.toExternal(r));
+ }
+ }
+
+ @Override
+ public ResultProvider setJobClient(JobClient jobClient) {
+ iterator.setJobClient(jobClient);
+ return this;
+ }
+
+ @Override
+ public CloseableIterator<RowData> toInternalIterator() {
+ initialize();
Review comment:
how about we introduce dedicated `initializeRowDataIterator()` and `initializeRowIterator()`? instead of instantiating both where one is unused.
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/result/BaseMaterializedResultTest.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.client.gateway.local.result;
+
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.binary.BinaryRowData;
+import org.apache.flink.table.data.conversion.DataStructureConverter;
+import org.apache.flink.table.data.conversion.DataStructureConverters;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.Row;
+
+import java.util.List;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class BaseMaterializedResultTest {
+
+ static Function<Row, BinaryRowData> createInternalBinaryRowDataConverter(DataType dataType) {
+ DataStructureConverter<Object, Object> converter =
+ DataStructureConverters.getConverter(dataType);
+ RowDataSerializer serializer = new RowDataSerializer((RowType) dataType.getLogicalType());
+
+ return row -> serializer.toBinaryRow((RowData) converter.toInternalOrNull(row)).copy();
+ }
+
+ static void assertRowEquals(
+ List<Row> expected,
+ List<RowData> actual,
+ DataStructureConverter<Object, Object> converter) {
Review comment:
use generics already here? `DataStructureConverter<Row, RowData>`
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResultTest.java
##########
@@ -80,41 +97,55 @@ public void testLimitedSnapshot() throws Exception {
ResolvedSchema schema =
ResolvedSchema.physical(
new String[] {"f0", "f1"},
- new DataType[] {DataTypes.STRING(), DataTypes.BIGINT()});
+ new DataType[] {DataTypes.STRING(), DataTypes.INT()});
+
+ DataStructureConverter<Object, Object> dataStructureConverter =
Review comment:
cast here already to `DataStructureConverter<Row, RowData>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727070139
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -466,8 +476,14 @@ private void executeStreamQueryTable(
IntStream.rangeClosed(1, result.getPayload())
.forEach(
(page) -> {
- for (Row row : executor.retrieveResultPage(resultID, page)) {
- actualResults.add(row.toString());
+ for (RowData row :
+ executor.retrieveResultPage(resultID, page)) {
+ actualResults.add(
+ StringUtils.arrayAwareToString(
Review comment:
`PrintUtils` might return nested arrays for `Row` and other structure types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
* f3d5c648bf84c4709dfc8baa512e5ba37b601873 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938797507
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bdce7016a9c5b7c806b22427e5fb9836c9052842 (Fri Oct 08 16:30:19 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
* f3d5c648bf84c4709dfc8baa512e5ba37b601873 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953)
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
* f3d5c648bf84c4709dfc8baa512e5ba37b601873 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953)
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a10760f62b70db58a953e0d8e304bafa56a053e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873)
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-942097735
This is ready for another pass. I also tested the sql client manually and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727078879
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java
##########
@@ -21,19 +21,39 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.core.execution.JobClient;
import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.data.RowData;
import org.apache.flink.types.Row;
import org.apache.flink.util.CloseableIterator;
/**
* An internal class which helps the client to get the execute result from a specific sink.
*
+ * <p>The two iterators are exclusive, that is you can use only one of the two at the same time.
+ *
* <p>This class is generated by specific sink and brings the result info to a {@link TableResult}.
*/
@Internal
-public interface CollectResultProvider {
+public interface ResultProvider {
/** Set the job client associated with the select job to retrieve the result. */
- void setJobClient(JobClient jobClient);
+ ResultProvider setJobClient(JobClient jobClient);
Review comment:
for fluency, which is useful in some call sites, i can remove it
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java
##########
@@ -21,19 +21,39 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.core.execution.JobClient;
import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.data.RowData;
import org.apache.flink.types.Row;
import org.apache.flink.util.CloseableIterator;
/**
* An internal class which helps the client to get the execute result from a specific sink.
*
+ * <p>The two iterators are exclusive, that is you can use only one of the two at the same time.
+ *
* <p>This class is generated by specific sink and brings the result info to a {@link TableResult}.
*/
@Internal
-public interface CollectResultProvider {
+public interface ResultProvider {
/** Set the job client associated with the select job to retrieve the result. */
- void setJobClient(JobClient jobClient);
+ ResultProvider setJobClient(JobClient jobClient);
Review comment:
for fluency, which is useful in some call sites, i can remove it if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873)
* d9f0f38dae789f563798b84266f7adbdf7daa0a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f3d5c648bf84c4709dfc8baa512e5ba37b601873 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953)
* 0040bfe2d73e9b07cf348fd91a6d93149689bebb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727080145
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
##########
@@ -269,6 +273,18 @@ private static Object formattedTimestamp(
formattedTimestamp(array.get(i), elementType, sessionTimeZone);
}
return formattedArray;
+ } else if (field instanceof ArrayData) {
Review comment:
I'm trying to avoid doing any additional change to `PrintUtils` right now, I just made the necessary ones to make the test pass. The goal of the parent issue FLINK-21456 is to rewrite completely that method anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a10760f62b70db58a953e0d8e304bafa56a053e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994)
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r726925586
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResultTest.java
##########
@@ -82,38 +109,53 @@ public void testLimitedSnapshot() throws Exception {
new String[] {"f0", "f1"},
new DataType[] {DataTypes.STRING(), DataTypes.BIGINT()});
+ DataStructureConverter<Object, Object> dataStructureConverter =
+ DataStructureConverters.getConverter(schema.toPhysicalRowDataType());
+ Function<Row, RowData> converter =
+ row -> (RowData) dataStructureConverter.toInternalOrNull(row);
+
try (TestMaterializedCollectBatchResult result =
new TestMaterializedCollectBatchResult(
new TestTableResult(ResultKind.SUCCESS_WITH_CONTENT, schema),
2, // limit the materialized table to 2 rows
3)) { // with 3 rows overcommitment
result.isRetrieving = true;
- result.processRecord(Row.of("D", 1));
- result.processRecord(Row.of("A", 1));
- result.processRecord(Row.of("B", 1));
- result.processRecord(Row.of("A", 1));
+ result.processRecord(converter.apply(Row.of("D", 1)));
Review comment:
instead of calling `converter.apply` we can introduce a helper method `toRowData`, this could even be put in a SQL Client test utils class
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -466,8 +476,14 @@ private void executeStreamQueryTable(
IntStream.rangeClosed(1, result.getPayload())
.forEach(
(page) -> {
- for (Row row : executor.retrieveResultPage(resultID, page)) {
- actualResults.add(row.toString());
+ for (RowData row :
+ executor.retrieveResultPage(resultID, page)) {
+ actualResults.add(
+ StringUtils.arrayAwareToString(
Review comment:
nit: Use `Arrays.toString` we don't expect nested arrays here
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/StaticResultProvider.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import java.util.List;
+import java.util.function.Function;
+
+/** Create result provider from a static set of data using external types. */
+@Internal
+public class StaticResultProvider implements ResultProvider {
Review comment:
package private?
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
##########
@@ -76,87 +83,91 @@ public void setUp() {
Column.physical("decimal(10, 5)", DataTypes.DECIMAL(10, 5)),
Column.physical("timestamp", DataTypes.TIMESTAMP(6)));
- data = new ArrayList<>();
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- 1,
- 2,
- "abc",
- BigDecimal.valueOf(1.23),
- Timestamp.valueOf("2020-03-01 18:39:14")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_BEFORE,
- false,
- null,
- 0,
- "",
- BigDecimal.valueOf(1),
- Timestamp.valueOf("2020-03-01 18:39:14.1")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_AFTER,
- true,
- Integer.MAX_VALUE,
- null,
- "abcdefg",
- BigDecimal.valueOf(1234567890),
- Timestamp.valueOf("2020-03-01 18:39:14.12")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- false,
- Integer.MIN_VALUE,
- Long.MAX_VALUE,
- null,
- BigDecimal.valueOf(12345.06789),
- Timestamp.valueOf("2020-03-01 18:39:14.123")));
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- true,
- 100,
- Long.MIN_VALUE,
- "abcdefg111",
- null,
- Timestamp.valueOf("2020-03-01 18:39:14.123456")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "abcdefghijklmnopqrstuvwxyz",
- BigDecimal.valueOf(-12345.06789),
- null));
-
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- -1,
- -1,
- "这是一段中文",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "これは日本語をテストするための文です",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- streamingData = new ArrayList<>();
- for (Row datum : data) {
- Row row = Row.copy(datum);
- streamingData.add(row);
- }
+ List<Row> rows =
+ Arrays.asList(
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ 1,
+ 2L,
+ "abc",
+ BigDecimal.valueOf(1.23),
+ Timestamp.valueOf("2020-03-01 18:39:14")),
+ Row.ofKind(
+ RowKind.UPDATE_BEFORE,
+ false,
+ null,
+ 0L,
+ "",
+ BigDecimal.valueOf(1),
+ Timestamp.valueOf("2020-03-01 18:39:14.1")),
+ Row.ofKind(
+ RowKind.UPDATE_AFTER,
+ true,
+ Integer.MAX_VALUE,
+ null,
+ "abcdefg",
+ BigDecimal.valueOf(12345),
+ Timestamp.valueOf("2020-03-01 18:39:14.12")),
+ Row.ofKind(
+ RowKind.DELETE,
+ false,
+ Integer.MIN_VALUE,
+ Long.MAX_VALUE,
+ null,
+ BigDecimal.valueOf(12345.06789),
+ Timestamp.valueOf("2020-03-01 18:39:14.123")),
+ Row.ofKind(
+ RowKind.INSERT,
+ true,
+ 100,
+ Long.MIN_VALUE,
+ "abcdefg111",
+ null,
+ Timestamp.valueOf("2020-03-01 18:39:14.123456")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "abcdefghijklmnopqrstuvwxyz",
+ BigDecimal.valueOf(-12345.06789),
+ null),
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ -1,
+ -1L,
+ "这是一段中文",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "これは日本語をテストするための文です",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")));
+
+ Function<Row, RowData> toInternalMapper =
Review comment:
ideally, the data should have been serialized once to model the production behavior, because it will be unlikely that `GenericRowData` will be used as input for the view
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/StaticResultProvider.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import java.util.List;
+import java.util.function.Function;
+
+/** Create result provider from a static set of data using external types. */
+@Internal
+public class StaticResultProvider implements ResultProvider {
+
+ private final List<Row> rows;
+ private final Function<Row, RowData> externalToInternalConverter;
Review comment:
why not using internal directly?
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
##########
@@ -269,6 +273,18 @@ private static Object formattedTimestamp(
formattedTimestamp(array.get(i), elementType, sessionTimeZone);
}
return formattedArray;
+ } else if (field instanceof ArrayData) {
Review comment:
a similar change should be necessary for nested `RowData`. how do structured types behave with this change?
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
##########
@@ -76,87 +83,91 @@ public void setUp() {
Column.physical("decimal(10, 5)", DataTypes.DECIMAL(10, 5)),
Column.physical("timestamp", DataTypes.TIMESTAMP(6)));
- data = new ArrayList<>();
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- 1,
- 2,
- "abc",
- BigDecimal.valueOf(1.23),
- Timestamp.valueOf("2020-03-01 18:39:14")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_BEFORE,
- false,
- null,
- 0,
- "",
- BigDecimal.valueOf(1),
- Timestamp.valueOf("2020-03-01 18:39:14.1")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_AFTER,
- true,
- Integer.MAX_VALUE,
- null,
- "abcdefg",
- BigDecimal.valueOf(1234567890),
- Timestamp.valueOf("2020-03-01 18:39:14.12")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- false,
- Integer.MIN_VALUE,
- Long.MAX_VALUE,
- null,
- BigDecimal.valueOf(12345.06789),
- Timestamp.valueOf("2020-03-01 18:39:14.123")));
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- true,
- 100,
- Long.MIN_VALUE,
- "abcdefg111",
- null,
- Timestamp.valueOf("2020-03-01 18:39:14.123456")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "abcdefghijklmnopqrstuvwxyz",
- BigDecimal.valueOf(-12345.06789),
- null));
-
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- -1,
- -1,
- "这是一段中文",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "これは日本語をテストするための文です",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- streamingData = new ArrayList<>();
- for (Row datum : data) {
- Row row = Row.copy(datum);
- streamingData.add(row);
- }
+ List<Row> rows =
+ Arrays.asList(
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ 1,
+ 2L,
+ "abc",
+ BigDecimal.valueOf(1.23),
+ Timestamp.valueOf("2020-03-01 18:39:14")),
+ Row.ofKind(
+ RowKind.UPDATE_BEFORE,
+ false,
+ null,
+ 0L,
+ "",
+ BigDecimal.valueOf(1),
+ Timestamp.valueOf("2020-03-01 18:39:14.1")),
+ Row.ofKind(
+ RowKind.UPDATE_AFTER,
+ true,
+ Integer.MAX_VALUE,
+ null,
+ "abcdefg",
+ BigDecimal.valueOf(12345),
+ Timestamp.valueOf("2020-03-01 18:39:14.12")),
+ Row.ofKind(
+ RowKind.DELETE,
+ false,
+ Integer.MIN_VALUE,
+ Long.MAX_VALUE,
+ null,
+ BigDecimal.valueOf(12345.06789),
+ Timestamp.valueOf("2020-03-01 18:39:14.123")),
+ Row.ofKind(
+ RowKind.INSERT,
+ true,
+ 100,
+ Long.MIN_VALUE,
+ "abcdefg111",
+ null,
+ Timestamp.valueOf("2020-03-01 18:39:14.123456")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "abcdefghijklmnopqrstuvwxyz",
+ BigDecimal.valueOf(-12345.06789),
+ null),
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ -1,
+ -1L,
+ "这是一段中文",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "これは日本語をテストするための文です",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")));
+
+ Function<Row, RowData> toInternalMapper =
Review comment:
either use `DataStructureConverters` to improve the readability of the code or better update the test data to use `List<RowData>` directly
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/utils/TestTableResult.java
##########
@@ -97,4 +101,27 @@ public ResultKind getResultKind() {
public void print() {
// do nothing
}
+
+ @Override
+ public CloseableIterator<RowData> collectInternal() {
+ DataStructureConverter<Object, Object> converter =
Review comment:
call the `open()` method of the converter
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java
##########
@@ -43,7 +42,7 @@
* @return used session identifier to track the session.
* @throws SqlExecutionException if any error happen
*/
- String openSession(@Nullable String sessionId) throws SqlExecutionException;
+ String openSession(@javax.annotation.Nullable String sessionId) throws SqlExecutionException;
Review comment:
undo this change
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/utils/TestTableResult.java
##########
@@ -97,4 +101,27 @@ public ResultKind getResultKind() {
public void print() {
// do nothing
}
+
+ @Override
+ public CloseableIterator<RowData> collectInternal() {
+ DataStructureConverter<Object, Object> converter =
+ DataStructureConverters.getConverter(resolvedSchema.toPhysicalRowDataType());
+ return new CloseableIterator<RowData>() {
Review comment:
nit: avoid anonymous inner classes and use static class instead
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResultTest.java
##########
@@ -44,34 +48,57 @@ public void testSnapshot() throws Exception {
new String[] {"f0", "f1"},
new DataType[] {DataTypes.STRING(), DataTypes.BIGINT()});
+ DataStructureConverter<Object, Object> dataStructureConverter =
+ DataStructureConverters.getConverter(schema.toPhysicalRowDataType());
+ Function<Row, RowData> converter =
+ row -> (RowData) dataStructureConverter.toInternalOrNull(row);
+
try (TestMaterializedCollectBatchResult result =
new TestMaterializedCollectBatchResult(
new TestTableResult(ResultKind.SUCCESS_WITH_CONTENT, schema),
Integer.MAX_VALUE)) {
result.isRetrieving = true;
- result.processRecord(Row.of("A", 1));
- result.processRecord(Row.of("B", 1));
- result.processRecord(Row.of("A", 1));
- result.processRecord(Row.of("C", 2));
+ result.processRecord(converter.apply(Row.of("A", 1)));
+ result.processRecord(converter.apply(Row.of("B", 1)));
+ result.processRecord(converter.apply(Row.of("A", 1)));
+ result.processRecord(converter.apply(Row.of("C", 2)));
assertEquals(TypedResult.payload(4), result.snapshot(1));
- assertEquals(Collections.singletonList(Row.of("A", 1)), result.retrievePage(1));
- assertEquals(Collections.singletonList(Row.of("B", 1)), result.retrievePage(2));
- assertEquals(Collections.singletonList(Row.of("A", 1)), result.retrievePage(3));
- assertEquals(Collections.singletonList(Row.of("C", 2)), result.retrievePage(4));
+ assertEquals(
+ Collections.singletonList(converter.apply(Row.of("A", 1))),
+ result.retrievePage(1));
+ assertEquals(
+ Collections.singletonList(converter.apply(Row.of("B", 1))),
+ result.retrievePage(2));
+ assertEquals(
+ Collections.singletonList(converter.apply(Row.of("A", 1))),
+ result.retrievePage(3));
+ assertEquals(
+ Collections.singletonList(converter.apply(Row.of("C", 2))),
+ result.retrievePage(4));
- result.processRecord(Row.of("A", 1));
+ result.processRecord(converter.apply(Row.of("A", 1)));
assertEquals(TypedResult.payload(5), result.snapshot(1));
- assertEquals(Collections.singletonList(Row.of("A", 1)), result.retrievePage(1));
- assertEquals(Collections.singletonList(Row.of("B", 1)), result.retrievePage(2));
- assertEquals(Collections.singletonList(Row.of("A", 1)), result.retrievePage(3));
- assertEquals(Collections.singletonList(Row.of("C", 2)), result.retrievePage(4));
- assertEquals(Collections.singletonList(Row.of("A", 1)), result.retrievePage(5));
+ assertEquals(
+ Collections.singletonList(converter.apply(Row.of("A", 1))),
Review comment:
instead of calling `assertEquals(Collections.singletonList(converter.apply(Row.of` many times, we can introduce a helper method that makes the code more readable
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/InsertResultProvider.java
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import javax.annotation.Nullable;
+
+import java.util.NoSuchElementException;
+import java.util.function.Supplier;
+
+/** A {@link ResultProvider} with custom wait logic for insert operation result. */
+@Internal
+class InsertResultProvider implements ResultProvider {
+
+ private final Long[] affectedRowCountsRow;
+
+ @Nullable private Boolean hasNext = null;
Review comment:
nit: for team consistency, can we write this as `private @Nullable Boolean hasNext`, next to the data type
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java
##########
@@ -145,12 +138,17 @@ public ResultKind getResultKind() {
@Override
public CloseableIterator<Row> collect() {
- return data;
+ return resultProvider.toExternalIterator();
+ }
+
+ @Override
+ public CloseableIterator<RowData> collectInternal() {
+ return resultProvider.toInternalIterator();
}
@Override
public void print() {
- Iterator<Row> it = collect();
+ Iterator<RowData> it = this.resultProvider.toInternalIterator();
Review comment:
nit: `this.` can be omitted
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java
##########
@@ -21,19 +21,39 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.core.execution.JobClient;
import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.data.RowData;
import org.apache.flink.types.Row;
import org.apache.flink.util.CloseableIterator;
/**
* An internal class which helps the client to get the execute result from a specific sink.
*
+ * <p>The two iterators are exclusive, that is you can use only one of the two at the same time.
+ *
* <p>This class is generated by specific sink and brings the result info to a {@link TableResult}.
*/
@Internal
-public interface CollectResultProvider {
+public interface ResultProvider {
/** Set the job client associated with the select job to retrieve the result. */
- void setJobClient(JobClient jobClient);
+ ResultProvider setJobClient(JobClient jobClient);
Review comment:
why has the result type changed from `void` to `ResultProvider`?
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1462,7 +1478,17 @@ private TableResult buildDescribeResult(ResolvedSchema schema) {
return new String[] {"name", "type", "null", "key", "extras", "watermark"};
}
- private TableResult buildShowColumnsResult(
+ private static RowData generateTableColumnsDataTypesConverter(Row row) {
+ return GenericRowData.of(
Review comment:
don't create a `Row` in the first place
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -124,17 +117,86 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
@Override
public DynamicTableSink copy() {
- final CollectDynamicSink copy =
- new CollectDynamicSink(
- tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
- // kind of violates the contract of copy() but should not harm
- // as it is null during optimization anyway until physical translation
- copy.iterator = iterator;
- return copy;
+ return new CollectDynamicSink(
+ tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
}
@Override
public String asSummaryString() {
return String.format("TableToCollect(type=%s)", consumedDataType);
}
+
+ private final class CollectResultProvider implements ResultProvider {
+
+ private CloseableRowIteratorWrapper<RowData> rowDataIterator;
+ private CloseableRowIteratorWrapper<Row> rowIterator;
+
+ private void initialize() {
+ if (this.rowIterator == null) {
+ this.rowDataIterator =
+ new CloseableRowIteratorWrapper<>(iterator, Function.identity());
+ this.rowIterator =
+ new CloseableRowIteratorWrapper<>(
+ iterator, r -> (Row) converter.toExternal(r));
+ }
+ }
+
+ @Override
+ public ResultProvider setJobClient(JobClient jobClient) {
+ iterator.setJobClient(jobClient);
+ return this;
+ }
+
+ @Override
+ public CloseableIterator<RowData> toInternalIterator() {
+ initialize();
+ return this.rowDataIterator;
+ }
+
+ @Override
+ public CloseableIterator<Row> toExternalIterator() {
+ initialize();
+ return this.rowIterator;
+ }
+
+ @Override
+ public boolean isFirstRowReady() {
+ initialize();
+ return this.rowDataIterator.firstRowProcessed
+ || this.rowIterator.firstRowProcessed
+ || iterator.hasNext();
+ }
+ }
+
+ private static final class CloseableRowIteratorWrapper<T> implements CloseableIterator<T> {
+ private final CloseableIterator<RowData> iterator;
+ private final Function<RowData, T> mapper;
Review comment:
we should avoid too many generic `Function<RowData, T>`, here we could simple use our `DataStructureConverter` class
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -124,17 +117,86 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
@Override
public DynamicTableSink copy() {
- final CollectDynamicSink copy =
- new CollectDynamicSink(
- tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
- // kind of violates the contract of copy() but should not harm
- // as it is null during optimization anyway until physical translation
- copy.iterator = iterator;
- return copy;
+ return new CollectDynamicSink(
+ tableIdentifier, consumedDataType, maxBatchSize, socketTimeout);
}
@Override
public String asSummaryString() {
return String.format("TableToCollect(type=%s)", consumedDataType);
}
+
+ private final class CollectResultProvider implements ResultProvider {
+
+ private CloseableRowIteratorWrapper<RowData> rowDataIterator;
+ private CloseableRowIteratorWrapper<Row> rowIterator;
+
+ private void initialize() {
+ if (this.rowIterator == null) {
+ this.rowDataIterator =
+ new CloseableRowIteratorWrapper<>(iterator, Function.identity());
+ this.rowIterator =
+ new CloseableRowIteratorWrapper<>(
+ iterator, r -> (Row) converter.toExternal(r));
+ }
+ }
+
+ @Override
+ public ResultProvider setJobClient(JobClient jobClient) {
+ iterator.setJobClient(jobClient);
+ return this;
+ }
+
+ @Override
+ public CloseableIterator<RowData> toInternalIterator() {
+ initialize();
+ return this.rowDataIterator;
+ }
+
+ @Override
+ public CloseableIterator<Row> toExternalIterator() {
+ initialize();
+ return this.rowIterator;
+ }
+
+ @Override
+ public boolean isFirstRowReady() {
+ initialize();
+ return this.rowDataIterator.firstRowProcessed
+ || this.rowIterator.firstRowProcessed
+ || iterator.hasNext();
+ }
+ }
+
+ private static final class CloseableRowIteratorWrapper<T> implements CloseableIterator<T> {
+ private final CloseableIterator<RowData> iterator;
+ private final Function<RowData, T> mapper;
Review comment:
the converter needs to be opened on the client side
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
##########
@@ -76,87 +83,91 @@ public void setUp() {
Column.physical("decimal(10, 5)", DataTypes.DECIMAL(10, 5)),
Column.physical("timestamp", DataTypes.TIMESTAMP(6)));
- data = new ArrayList<>();
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- 1,
- 2,
- "abc",
- BigDecimal.valueOf(1.23),
- Timestamp.valueOf("2020-03-01 18:39:14")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_BEFORE,
- false,
- null,
- 0,
- "",
- BigDecimal.valueOf(1),
- Timestamp.valueOf("2020-03-01 18:39:14.1")));
- data.add(
- Row.ofKind(
- RowKind.UPDATE_AFTER,
- true,
- Integer.MAX_VALUE,
- null,
- "abcdefg",
- BigDecimal.valueOf(1234567890),
- Timestamp.valueOf("2020-03-01 18:39:14.12")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- false,
- Integer.MIN_VALUE,
- Long.MAX_VALUE,
- null,
- BigDecimal.valueOf(12345.06789),
- Timestamp.valueOf("2020-03-01 18:39:14.123")));
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- true,
- 100,
- Long.MIN_VALUE,
- "abcdefg111",
- null,
- Timestamp.valueOf("2020-03-01 18:39:14.123456")));
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "abcdefghijklmnopqrstuvwxyz",
- BigDecimal.valueOf(-12345.06789),
- null));
-
- data.add(
- Row.ofKind(
- RowKind.INSERT,
- null,
- -1,
- -1,
- "这是一段中文",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- data.add(
- Row.ofKind(
- RowKind.DELETE,
- null,
- -1,
- -1,
- "これは日本語をテストするための文です",
- BigDecimal.valueOf(-12345.06789),
- Timestamp.valueOf("2020-03-04 18:39:14")));
-
- streamingData = new ArrayList<>();
- for (Row datum : data) {
- Row row = Row.copy(datum);
- streamingData.add(row);
- }
+ List<Row> rows =
+ Arrays.asList(
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ 1,
+ 2L,
+ "abc",
+ BigDecimal.valueOf(1.23),
+ Timestamp.valueOf("2020-03-01 18:39:14")),
+ Row.ofKind(
+ RowKind.UPDATE_BEFORE,
+ false,
+ null,
+ 0L,
+ "",
+ BigDecimal.valueOf(1),
+ Timestamp.valueOf("2020-03-01 18:39:14.1")),
+ Row.ofKind(
+ RowKind.UPDATE_AFTER,
+ true,
+ Integer.MAX_VALUE,
+ null,
+ "abcdefg",
+ BigDecimal.valueOf(12345),
+ Timestamp.valueOf("2020-03-01 18:39:14.12")),
+ Row.ofKind(
+ RowKind.DELETE,
+ false,
+ Integer.MIN_VALUE,
+ Long.MAX_VALUE,
+ null,
+ BigDecimal.valueOf(12345.06789),
+ Timestamp.valueOf("2020-03-01 18:39:14.123")),
+ Row.ofKind(
+ RowKind.INSERT,
+ true,
+ 100,
+ Long.MIN_VALUE,
+ "abcdefg111",
+ null,
+ Timestamp.valueOf("2020-03-01 18:39:14.123456")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "abcdefghijklmnopqrstuvwxyz",
+ BigDecimal.valueOf(-12345.06789),
+ null),
+ Row.ofKind(
+ RowKind.INSERT,
+ null,
+ -1,
+ -1L,
+ "这是一段中文",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")),
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ -1,
+ -1L,
+ "これは日本語をテストするための文です",
+ BigDecimal.valueOf(-12345.06789),
+ Timestamp.valueOf("2020-03-04 18:39:14")));
+
+ Function<Row, RowData> toInternalMapper =
Review comment:
also test a more complex type such as array, map, or nested row
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1298,7 +1304,12 @@ public TableResult executeInternal(Operation operation) {
}
}
- private TableResult createCatalog(CreateCatalogOperation operation) {
+ private static RowData convertOneColumnStringRow(Row row) {
Review comment:
don't create a `Row` in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdce7016a9c5b7c806b22427e5fb9836c9052842 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
}, {
"hash" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
* c00b3bb2898a2dbe6f7e9b265ef38b14418cd3ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17441:
URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873",
"triggerID" : "bdce7016a9c5b7c806b22427e5fb9836c9052842",
"triggerType" : "PUSH"
}, {
"hash" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24937",
"triggerID" : "d9f0f38dae789f563798b84266f7adbdf7daa0a3",
"triggerType" : "PUSH"
}, {
"hash" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24953",
"triggerID" : "f3d5c648bf84c4709dfc8baa512e5ba37b601873",
"triggerType" : "PUSH"
}, {
"hash" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24958",
"triggerID" : "0040bfe2d73e9b07cf348fd91a6d93149689bebb",
"triggerType" : "PUSH"
}, {
"hash" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24994",
"triggerID" : "5a10760f62b70db58a953e0d8e304bafa56a053e",
"triggerType" : "PUSH"
}, {
"hash" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188",
"triggerID" : "e78df5a2a0572a2cfe043bf7737f1e52fe9f89af",
"triggerType" : "PUSH"
}, {
"hash" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200",
"triggerID" : "f1d2c7353068ba68ea33fbbedab6b7c25020dd62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25188)
* f1d2c7353068ba68ea33fbbedab6b7c25020dd62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org