You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/10/01 22:27:32 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8332:
[fix] make names non-nullable
codecov-io edited a comment on issue #8332: [fix] make names non-nullable
URL: https://github.com/apache/incubator-superset/pull/8332#issuecomment-537258542
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=h1) Report
> Merging [#8332](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c708037e8f94bf5e2898f50f2a096aaf4a97ad6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8332 +/- ##
==========================================
- Coverage 67.67% 67.65% -0.03%
==========================================
Files 447 447
Lines 22648 22648
Branches 2363 2363
==========================================
- Hits 15328 15323 -5
- Misses 7182 7187 +5
Partials 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8332/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.41% <100%> (ø)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8332/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <100%> (ø)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8332/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.96% <100%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8332/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `77.41% <0%> (-16.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=footer). Last update [8c70803...f9d6566](https://codecov.io/gh/apache/incubator-superset/pull/8332?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org