You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@visi.com> on 2008/01/06 23:43:20 UTC
Re: svn commit: r609434 - in /openejb/trunk/openejb3/container/openejb-core/src/main: java/org/apache/openejb/config/ java/org/apache/openejb/core/entity/ java/org/apache/openejb/core/ivm/ java/org/apache/openejb/core/transaction/ resources/ resources/org/...
On Jan 6, 2008, at 2:09 PM, jlaskowski@apache.org wrote:
> --- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
> apache/openejb/core/transaction/TransactionPolicy.java (original)
> +++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
> apache/openejb/core/transaction/TransactionPolicy.java Sun Jan 6
> 14:09:22 2008
> @@ -216,8 +216,7 @@
> }
>
> protected void logSystemException(Throwable sysException) {
> -
> - logger.error("The bean instances business method
> encountered a system exception: " + sysException.getMessage(),
> sysException);
> + logger.debug("startup.beanInstanceSystemExceptionThrown",
> sysException, sysException.getMessage());
> }
>
> protected void discardBeanInstance(Object instance,
> ThreadContext callContext) {
The tricky thing about lowering the level on this message is
callbacks. On a callback method invoked by the container, this error
message is the only indication the user has that something went
wrong. Maybe we can figure out a way to have two log levels, one for
business methods where the will actually get some form of the
exception thrown to them and one for callbacks where the log file is
their only source of information.
-David
Re: svn commit: r609434 - in /openejb/trunk/openejb3/container/openejb-core/src/main: java/org/apache/openejb/config/ java/org/apache/openejb/core/entity/ java/org/apache/openejb/core/ivm/ java/org/apache/openejb/core/transaction/ resources/ resources/org/...
Posted by David Blevins <da...@visi.com>.
On Jan 6, 2008, at 2:43 PM, David Blevins wrote:
> Maybe we can figure out a way to have two log levels, one for
> business methods where the will actually get some form of the
> exception thrown to them and one for callbacks where the log file is
> their only source of information.
Figured out how to get that in there.
-David
Re: svn commit: r609434 - in /openejb/trunk/openejb3/container/openejb-core/src/main: java/org/apache/openejb/config/ java/org/apache/openejb/core/entity/ java/org/apache/openejb/core/ivm/ java/org/apache/openejb/core/transaction/ resources/ resources/org/...
Posted by Dain Sundstrom <da...@iq80.com>.
On Jan 6, 2008, at 2:43 PM, David Blevins wrote:
> On Jan 6, 2008, at 2:09 PM, jlaskowski@apache.org wrote:
>
>> --- openejb/trunk/openejb3/container/openejb-core/src/main/java/
>> org/apache/openejb/core/transaction/TransactionPolicy.java (original)
>> +++ openejb/trunk/openejb3/container/openejb-core/src/main/java/
>> org/apache/openejb/core/transaction/TransactionPolicy.java Sun
>> Jan 6 14:09:22 2008
>> @@ -216,8 +216,7 @@
>> }
>>
>> protected void logSystemException(Throwable sysException) {
>> -
>> - logger.error("The bean instances business method
>> encountered a system exception: " + sysException.getMessage(),
>> sysException);
>> + logger.debug("startup.beanInstanceSystemExceptionThrown",
>> sysException, sysException.getMessage());
>> }
>>
>> protected void discardBeanInstance(Object instance,
>> ThreadContext callContext) {
>
> The tricky thing about lowering the level on this message is
> callbacks. On a callback method invoked by the container, this
> error message is the only indication the user has that something
> went wrong. Maybe we can figure out a way to have two log levels,
> one for business methods where the will actually get some form of
> the exception thrown to them and one for callbacks where the log
> file is their only source of information.
In the mean time, should we switch this back to error?
-dain