You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2010/11/15 10:56:14 UTC
[jira] Created: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Hedwig c++ client uses a non thread safe logging library
--------------------------------------------------------
Key: ZOOKEEPER-930
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
Project: Zookeeper
Issue Type: Bug
Components: contrib-hedwig
Affects Versions: 3.3.2
Reporter: Ivan Kelly
Assignee: Ivan Kelly
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932205#action_12932205 ]
Michi Mutsuzaki commented on ZOOKEEPER-930:
-------------------------------------------
+1.
Thank you Ivan for the quick patch!
--Michi
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932021#action_12932021 ]
Ivan Kelly commented on ZOOKEEPER-930:
--------------------------------------
Moved from log4cpp to log4cxx.
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-930:
---------------------------------
Status: Open (was: Patch Available)
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-930:
---------------------------------
Status: Patch Available (was: Open)
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932163#action_12932163 ]
Benjamin Reed commented on ZOOKEEPER-930:
-----------------------------------------
looks good ivan. you should probably mention that you are moving to log4cxx for thread safety issues. the one minor thing: you messed up the indentation on a couple of lines. can you fix those?
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932196#action_12932196 ]
Hadoop QA commented on ZOOKEEPER-930:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459592/ZOOKEEPER-930.patch
against trunk revision 1034003.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/29//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/29//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/29//console
This message is automatically generated.
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-930:
---------------------------------
Attachment: ZOOKEEPER-930.patch
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932583#action_12932583 ]
Benjamin Reed commented on ZOOKEEPER-930:
-----------------------------------------
thanx ivan!
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932387#action_12932387 ]
Hadoop QA commented on ZOOKEEPER-930:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459691/ZOOKEEPER-930.patch
against trunk revision 1034003.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/30//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/30//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/30//console
This message is automatically generated.
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932379#action_12932379 ]
Ivan Kelly commented on ZOOKEEPER-930:
--------------------------------------
As the title says, log4cpp is not thread safe and not really maintained afaics. Moving to log4cxx, which is an apache project. Uploaded a new diff with indentation fixes.
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non
thread safe logging library
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932895#action_12932895 ]
Hudson commented on ZOOKEEPER-930:
----------------------------------
Integrated in ZooKeeper-trunk #1005 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1005/])
ZOOKEEPER-930. Hedwig c++ client uses a non thread safe logging library
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-930:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 1035727.
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-930:
---------------------------------
Status: Patch Available (was: Open)
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-930) Hedwig c++ client uses a non thread
safe logging library
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-930:
---------------------------------
Attachment: ZOOKEEPER-930.patch
> Hedwig c++ client uses a non thread safe logging library
> --------------------------------------------------------
>
> Key: ZOOKEEPER-930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-hedwig
> Affects Versions: 3.3.2
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: ZOOKEEPER-930.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.