You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 03:22:56 UTC

[GitHub] [doris] yixiutt opened a new pull request, #15638: [bugfix](vertical compaction) fix dcheck failed in MOW tablet

yixiutt opened a new pull request, #15638:
URL: https://github.com/apache/doris/pull/15638

   fix a dcheck error for vertical compaction on Merge-On-Write table。 When merge rowsets with empty segment, VerticalHeapMergeIterator::init return ok directly and _record_rowids not set, dcheck failed when _unique_key_next_block call current_block_row_locations。
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #15638: [bugfix](vertical compaction) fix dcheck failed on MOW tablet

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15638:
URL: https://github.com/apache/doris/pull/15638#issuecomment-1371843760

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.84 seconds
    load time: 472 seconds
    storage size: 17122696921 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105064942_clickbench_pr_73966.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] dataroaring merged pull request #15638: [bugfix](vertical compaction) fix dcheck failed on MOW tablet

Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #15638:
URL: https://github.com/apache/doris/pull/15638


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15638: [bugfix](vertical compaction) fix dcheck failed on MOW tablet

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15638:
URL: https://github.com/apache/doris/pull/15638#issuecomment-1371742664

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15638: [bugfix](vertical compaction) fix dcheck failed on MOW tablet

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15638:
URL: https://github.com/apache/doris/pull/15638#issuecomment-1371742688

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org