You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/10/09 22:05:20 UTC
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11634
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
IMPALA-7684: Fix Admission result printed in the query profile
With this patch the right result is printed for the admission result
when the query is admitted immediately vs when it is admitted after
being queued.
Testing:
Added coverage for checking the result for these two cases to an
existing test.
Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
---
M be/src/scheduling/admission-controller.cc
M tests/custom_cluster/test_admission_controller.py
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/11634/1
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3296/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 09 Oct 2018 23:07:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 10 Oct 2018 03:00:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1001/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:42:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
IMPALA-7684: Fix Admission result printed in the query profile
With this patch the right result is printed for the admission result
when the query is admitted immediately vs when it is admitted after
being queued.
Testing:
Added coverage for checking the result for these two cases to an
existing test.
Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Reviewed-on: http://gerrit.cloudera.org:8080/11634
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/admission-controller.cc
M tests/custom_cluster/test_admission_controller.py
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 09 Oct 2018 23:07:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7684: Fix Admission result printed in the query profile
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11634 )
Change subject: IMPALA-7684: Fix Admission result printed in the query profile
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I410993a555d9590cca42902fbfa1fe7aa883be06
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:37:47 +0000
Gerrit-HasComments: No