You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/05/18 15:23:11 UTC
[GitHub] [systemml] phaniarnab opened a new pull request #915: [SYSTEMDS-335]Updated weighted scheme for lineage cache eviction.
phaniarnab opened a new pull request #915:
URL: https://github.com/apache/systemml/pull/915
This patch updates the weighted scheme by adding an elaborated scoring function. The function has two components - a ratio of compute time, in-memory size, and a last-used timestamp. The components are associated with weights, which can tune the eviction policies (e.g. weights 0 and 1 for time/size and timestamp respectively translate to LRU scheme). This patch also replaces the earlier PriorityQueye by a TreeSet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] phaniarnab commented on pull request #915: [SYSTEMDS-335]Updated weighted scheme for lineage cache eviction.
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #915:
URL: https://github.com/apache/systemml/pull/915#issuecomment-633402171
This patch is ready to be merged in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] mboehm7 commented on pull request #915: [SYSTEMDS-335]Updated weighted scheme for lineage cache eviction.
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #915:
URL: https://github.com/apache/systemml/pull/915#issuecomment-634216823
LGTM - thanks for adding the test. During the merge I only fixed some minor formatting issues (tabs between code and comments, ordering of members, enums, static initializers, and methods) as well as a slight modification of DNN tests to make them less prone to surefire failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] asfgit closed pull request #915: [SYSTEMDS-335]Updated weighted scheme for lineage cache eviction.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #915:
URL: https://github.com/apache/systemml/pull/915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] mboehm7 commented on pull request #915: [SYSTEMDS-335]Updated weighted scheme for lineage cache eviction.
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #915:
URL: https://github.com/apache/systemml/pull/915#issuecomment-631747477
Great - thanks @phaniarnab, I like the generalization, but could you please also add a test that systematically uses all available cache eviction policies (via some use case that quickly fills the available lineage cache)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org