[jira] [Commented] (SOLR-6177) Logging message for DirectUpdateHandler2 should mention core name

["Varun Thacker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059985#comment-14059985 ] 

Varun Thacker commented on SOLR-6177:
-------------------------------------

SolrLogLayout adds core name but in it's short form - a shortId which is a notation like "C1". 

This doesn't help to much, as it's cryptic and at no place do we actually print the mapping between "C1" -> actual core name. Lots of places explicitly mention the core name by calling core.getLogId() . 

Either we add core.getLogId() to places where we need them or we could actually change the logic of shortId to name the actual core name and remove all the usages of core.getLogId()

> Logging message for DirectUpdateHandler2 should mention core name
> -----------------------------------------------------------------
>
>                 Key: SOLR-6177
>                 URL: https://issues.apache.org/jira/browse/SOLR-6177
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>            Priority: Minor
>             Fix For: 5.0, 4.10
>
>         Attachments: SOLR-6177.patch
>
>
> While looking at logs in a multi core setup, it's tough to figure out for which core was commit called for.
> It would be nice if we included the core name in the logging messages in DirectUpdateHandler2 to make it easier to read logs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org