You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2010/08/14 01:05:56 UTC

svn commit: r985398 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

Author: ivaynberg
Date: Fri Aug 13 23:05:55 2010
New Revision: 985398

URL: http://svn.apache.org/viewvc?rev=985398&view=rev
Log:
better fix

Modified:
    wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java?rev=985398&r1=985397&r2=985398&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java Fri Aug 13 23:05:55 2010
@@ -22,7 +22,6 @@ import org.apache.wicket.RequestContext;
 import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.model.IModel;
-import org.apache.wicket.request.Url;
 import org.apache.wicket.request.handler.ListenerInterfaceRequestHandler;
 import org.apache.wicket.request.handler.PageAndComponentProvider;
 
@@ -179,9 +178,8 @@ public class DropDownChoice<T> extends A
 		{
 			// we do not want relative URL here, because it will be used by
 			// Form#dispatchEvent
-			Url url = getRequestCycle().urlFor(
-				new ListenerInterfaceRequestHandler(new PageAndComponentProvider(getPage(), this),
-					IOnChangeListener.INTERFACE));
+			CharSequence url = urlFor(new ListenerInterfaceRequestHandler(
+				new PageAndComponentProvider(getPage(), this), IOnChangeListener.INTERFACE));
 
 			Form<?> form = findParent(Form.class);
 			if (form != null)
@@ -202,8 +200,7 @@ public class DropDownChoice<T> extends A
 				// TODO: following doesn't work with portlets, should be posted to a dynamic hidden
 				// form
 				// with an ActionURL or something
-				tag.put("onchange", "window.location.href='" +
-					getRequestCycle().getUrlRenderer().renderUrl(url) +
+				tag.put("onchange", "window.location.href='" + url +
 					(url.toString().indexOf('?') > -1 ? "&amp;" : "?") + getInputName() +
 					"=' + this.options[this.selectedIndex].value;");
 			}