You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gora.apache.org by dr...@apache.org on 2020/03/21 23:47:50 UTC
[gora] branch GORA-647-test-containers-mongo updated: GORA-647
Avoid using String.format
This is an automated email from the ASF dual-hosted git repository.
drazzib pushed a commit to branch GORA-647-test-containers-mongo
in repository https://gitbox.apache.org/repos/asf/gora.git
The following commit(s) were added to refs/heads/GORA-647-test-containers-mongo by this push:
new 0c2986f GORA-647 Avoid using String.format
0c2986f is described below
commit 0c2986f837cf6051718f565e5b7684d792937967
Author: Damien Raude-Morvan <dr...@drazzib.com>
AuthorDate: Sun Mar 22 00:47:41 2020 +0100
GORA-647 Avoid using String.format
---
.../src/test/java/org/apache/gora/mongodb/GoraMongodbTestDriver.java | 3 +--
.../mongodb/authentications/GoraMongodbAuthenticationTestDriver.java | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/gora-mongodb/src/test/java/org/apache/gora/mongodb/GoraMongodbTestDriver.java b/gora-mongodb/src/test/java/org/apache/gora/mongodb/GoraMongodbTestDriver.java
index 9859b1c..df6e4ed 100644
--- a/gora-mongodb/src/test/java/org/apache/gora/mongodb/GoraMongodbTestDriver.java
+++ b/gora-mongodb/src/test/java/org/apache/gora/mongodb/GoraMongodbTestDriver.java
@@ -57,8 +57,7 @@ public class GoraMongodbTestDriver extends GoraTestDriver {
// Store Mongo server "host:port" in Hadoop configuration
// so that MongoStore will be able to get it latter
- String mongoServersProp = String.format("%s:%d", host, port);
- conf.set(MongoStoreParameters.PROP_MONGO_SERVERS, mongoServersProp);
+ conf.set(MongoStoreParameters.PROP_MONGO_SERVERS, host + ":" + port);
log.info("Starting embedded Mongodb server on {} port.", port);
try {
diff --git a/gora-mongodb/src/test/java/org/apache/gora/mongodb/authentications/GoraMongodbAuthenticationTestDriver.java b/gora-mongodb/src/test/java/org/apache/gora/mongodb/authentications/GoraMongodbAuthenticationTestDriver.java
index b96fa7f..b7d2c9e 100644
--- a/gora-mongodb/src/test/java/org/apache/gora/mongodb/authentications/GoraMongodbAuthenticationTestDriver.java
+++ b/gora-mongodb/src/test/java/org/apache/gora/mongodb/authentications/GoraMongodbAuthenticationTestDriver.java
@@ -61,9 +61,8 @@ class GoraMongodbAuthenticationTestDriver extends GoraTestDriver {
ServerAddress address = _container.getServerAddress();
int port = address.getPort();
String host = address.getHost();
- String mongoServersProp = String.format("%s:%d", host, port);
- conf.set(MongoStoreParameters.PROP_MONGO_SERVERS, mongoServersProp);
+ conf.set(MongoStoreParameters.PROP_MONGO_SERVERS, host + ":" + port);
conf.set(MongoStoreParameters.PROP_MONGO_DB, "admin");
conf.set(MongoStoreParameters.PROP_MONGO_AUTHENTICATION_TYPE, authMechanisms);
conf.set(MongoStoreParameters.PROP_MONGO_LOGIN, adminUsername);