You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/13 12:43:19 UTC
[GitHub] [flink] akalash opened a new pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
akalash opened a new pull request #18351:
URL: https://github.com/apache/flink/pull/18351
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Added one more limit case for buffer debloat in documentation*
## Verifying this change
Nothing. It is documentation
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f446851b1c93b77641f36e8c8854773637818311",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393",
"triggerID" : "f446851b1c93b77641f36e8c8854773637818311",
"triggerType" : "PUSH"
}, {
"hash" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f446851b1c93b77641f36e8c8854773637818311 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393)
* 6fd86437e9bc448215bf55b289b1a980cbf8b373 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f446851b1c93b77641f36e8c8854773637818311",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393",
"triggerID" : "f446851b1c93b77641f36e8c8854773637818311",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f446851b1c93b77641f36e8c8854773637818311 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #18351:
URL: https://github.com/apache/flink/pull/18351#discussion_r786089010
##########
File path: docs/content.zh/docs/deployment/memory/network_mem_tuning.md
##########
@@ -87,6 +83,12 @@ Flink 1.14 新引入的缓冲消胀机制尝试通过自动调整缓冲数据量
此外，如果您想减少缓冲数据量使其低于缓冲消胀当前允许的量，您可能需要手动的设置缓冲区的个数。
+#### High parallelism
+
+Currently, the buffer debloating mechanism can work correctly only by some parallelism values limit. When the parallelism exceeds this value, then increasing checkpoint time and decreasing throughput can be observed. The best way to fix this situation is to increase the number of buffers(`taskmanager.network.memory.buffers-per-channel`, `taskmanager.network.memory.floating-buffers-per-gate`)
Review comment:
I have updated the commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #18351:
URL: https://github.com/apache/flink/pull/18351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f446851b1c93b77641f36e8c8854773637818311",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393",
"triggerID" : "f446851b1c93b77641f36e8c8854773637818311",
"triggerType" : "PUSH"
}, {
"hash" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29577",
"triggerID" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f446851b1c93b77641f36e8c8854773637818311 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393)
* 6fd86437e9bc448215bf55b289b1a980cbf8b373 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f446851b1c93b77641f36e8c8854773637818311",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393",
"triggerID" : "f446851b1c93b77641f36e8c8854773637818311",
"triggerType" : "PUSH"
}, {
"hash" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29577",
"triggerID" : "6fd86437e9bc448215bf55b289b1a980cbf8b373",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fd86437e9bc448215bf55b289b1a980cbf8b373 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #18351:
URL: https://github.com/apache/flink/pull/18351#discussion_r785910240
##########
File path: docs/content.zh/docs/deployment/memory/network_mem_tuning.md
##########
@@ -87,6 +83,12 @@ Flink 1.14 新引入的缓冲消胀机制尝试通过自动调整缓冲数据量
此外，如果您想减少缓冲数据量使其低于缓冲消胀当前允许的量，您可能需要手动的设置缓冲区的个数。
+#### High parallelism
+
+Currently, the buffer debloating mechanism can work correctly only by some parallelism values limit. When the parallelism exceeds this value, then increasing checkpoint time and decreasing throughput can be observed. The best way to fix this situation is to increase the number of buffers(`taskmanager.network.memory.buffers-per-channel`, `taskmanager.network.memory.floating-buffers-per-gate`)
Review comment:
Maybe something like this?
```suggestion
Currently, the buffer debloating mechanism might not perform correctly with high parallelism (above ~200) using the default configuration. If you observe reduced throughput or higher than expected checkpointing times we suggest to increase the number of floating buffers (`taskmanager.network.memory.floating-buffers-per-gate`) from the default value to at least the number equal to the parallelism.
```
##########
File path: docs/content.zh/docs/deployment/memory/network_mem_tuning.md
##########
@@ -87,6 +83,12 @@ Flink 1.14 新引入的缓冲消胀机制尝试通过自动调整缓冲数据量
此外，如果您想减少缓冲数据量使其低于缓冲消胀当前允许的量，您可能需要手动的设置缓冲区的个数。
+#### High parallelism
+
+Currently, the buffer debloating mechanism can work correctly only by some parallelism values limit. When the parallelism exceeds this value, then increasing checkpoint time and decreasing throughput can be observed. The best way to fix this situation is to increase the number of buffers(`taskmanager.network.memory.buffers-per-channel`, `taskmanager.network.memory.floating-buffers-per-gate`)
Review comment:
Plus please brake long lines so that resolving conflicts in the future is easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18351: [FLINK-25646][docs] Added "High parallelism" limitation for buffer debloating docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18351:
URL: https://github.com/apache/flink/pull/18351#issuecomment-1012106731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f446851b1c93b77641f36e8c8854773637818311",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393",
"triggerID" : "f446851b1c93b77641f36e8c8854773637818311",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f446851b1c93b77641f36e8c8854773637818311 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29393)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org