You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/08 08:35:54 UTC
[GitHub] [apisix] spacewander opened a new pull request #4005: feat: support upstream mTLS
spacewander opened a new pull request #4005:
URL: https://github.com/apache/apisix/pull/4005
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4005: feat: support upstream mTLS
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4005:
URL: https://github.com/apache/apisix/pull/4005#discussion_r610349805
##########
File path: apisix/upstream.lua
##########
@@ -279,6 +291,25 @@ function _M.set_by_route(route, api_ctx)
api_ctx.up_checker = checker
end
+ if up_conf.scheme == "https" and up_conf.tls then
Review comment:
OK, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #4005: feat: support upstream mTLS
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #4005:
URL: https://github.com/apache/apisix/pull/4005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4005: feat: support upstream mTLS
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4005:
URL: https://github.com/apache/apisix/pull/4005#discussion_r610298711
##########
File path: apisix/upstream.lua
##########
@@ -279,6 +291,25 @@ function _M.set_by_route(route, api_ctx)
api_ctx.up_checker = checker
end
+ if up_conf.scheme == "https" and up_conf.tls then
Review comment:
Yes, we can do it in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4005: feat: support upstream mTLS
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4005:
URL: https://github.com/apache/apisix/pull/4005#discussion_r610275842
##########
File path: apisix/upstream.lua
##########
@@ -279,6 +291,25 @@ function _M.set_by_route(route, api_ctx)
api_ctx.up_checker = checker
end
+ if up_conf.scheme == "https" and up_conf.tls then
Review comment:
Shall we also support mTLS for `grpcs` in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org