[GitHub] [superset] codyml commented on pull request #20684: fix(dashboard): Fix missing metadata on draggable dashboard edit chart cards

[GitBox <gi...@apache.org>]

codyml commented on PR #20684:
URL: https://github.com/apache/superset/pull/20684#issuecomment-1309483293

   @john-bodley Thanks for the follow-up!  Those points make a lot of sense to me and it sounds like there's definitely room for improvement.
   
   From what I remember, no one at Preset was clamoring for being able to add charts that you don't own to a dashboard (cc @lauderbaugh in case I'm wrong).  I think I chose this approach just because it seemed like the easiest way to resolve the missing metadata bug caused by the list trying to display charts that you don't own that were already added to the dashboard.
   
   I like the idea of a toggle – that sounds like a best of both worlds solution.  A bandaid solution could also be to revert this change and solve the missing metadata issue by just not trying to show charts added to the dashboard that you don't own in the list at all.  The downside of that would be that if you remove a chart you don't own from a dashboard there would be no way to get it back.  But, that was already sort of a problem before this PR: if you removed a chart you didn't own and then saved the dashboard, you wouldn't be able to add it back from the dashboard edit list.
   
   Is changing this behavior something that you'd like to work on?  Happy to discuss these or any other ideas further or do any PR reviews as helpful – let me know!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org