[GitHub] [lucene] jtibshirani commented on a change in pull request #232: LUCENE-10043: Decrease default LRUQueryCache#skipCacheFactor to 10

[GitBox <gi...@apache.org>]

jtibshirani commented on a change in pull request #232:
URL: https://github.com/apache/lucene/pull/232#discussion_r686703128



##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -146,7 +146,7 @@ public LRUQueryCache(
    * of the top-level query will be cached in order to not hurt latency too much because of caching.
    */
   public LRUQueryCache(int maxSize, long maxRamBytesUsed) {
-    this(maxSize, maxRamBytesUsed, new MinSegmentSizePredicate(10000, .03f), 250);
+    this(maxSize, maxRamBytesUsed, new MinSegmentSizePredicate(10000, .03f), 10);

Review comment:
       I plan to do this refactor in a follow-up on 9.0 only, to avoid changing the APIs too much on 8.x.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org