You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/11 02:50:59 UTC
[GitHub] [dolphinscheduler] QuakeWang opened a new issue, #9426: [Bug] [Doc] Image can not display properly
QuakeWang opened a new issue, #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Due to the migration of the documents directly from [website](https://github.com/apache/dolphinscheduler-website), some of the file paths were incorrect, thus preventing the images from being displayed properly.
### What you expected to happen
Modify the path so as to ensure that the images can be displayed properly.
### How to reproduce
You can see the problem at this [link](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/guide/task/datax.md). The situation is similar to the other documents.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1094589337
We could make our image work in both GitHub and dolphinscheduler-website too. All we have to do is change img related path in dolphinschedule repo, and add a convertor in https://github.com/apache/dolphinscheduler-website/blob/master/scripts/prepare_docs.sh to convert the image path in dolphinscheduler-website repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #9426: [Bug] [Doc] Image can not display properly
URL: https://github.com/apache/dolphinscheduler/issues/9426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] QuakeWang commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1143196595
> > > after [apache/dolphinscheduler-website#789](https://github.com/apache/dolphinscheduler-website/pull/789) merged, we could change all our img path from `/img` to related path
> >
> >
> > Do you mean we can use `... /... /... /... /img/tasks/demo/` to replace `/img/tasks/demo` at now ?
>
> Yeah, after [apache/dolphinscheduler-website#789](https://github.com/apache/dolphinscheduler-website/pull/789) we can do that
Ok, I will do this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1094578890
Could you give some examples of the bad path image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1140613307
>
It could, but it will break the link on our website https://dolphinscheduler.apache.org/. So we also need to add some script in our website to avoid it being broken, and already have one in https://github.com/apache/dolphinscheduler-website/pull/789 by @huangchenguang123 . But it is related PR #10127 only correct conditions task type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] QuakeWang commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1143133968
> after [apache/dolphinscheduler-website#789](https://github.com/apache/dolphinscheduler-website/pull/789) merged, we could change all our img path from `/img` to related path
Do you mean we can use `... /... /... /... /img/tasks/demo/` to replace `/img/tasks/demo` at now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1141742348
And I will find some easy way to batch operator them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #9426: [Bug] [Doc] Image can not display properly
URL: https://github.com/apache/dolphinscheduler/issues/9426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] QuakeWang commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1139534936
I found that using relative paths in documents such as `... /... /... /... /img/tasks/demo/`. Instead of absolute paths, e.g. `/img/tasks/demo`. The image will be displayed normally. So do we need to change the path to the image?
@zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1094489846
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1124403854
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1094587241
oh, I got it, you view it in the github itself do you? Although we migrate docs from dolphinscheduler-website to dolphinscheduler. we still keep the old link of the image on dolphinscheduler-website. It means that we could only view the img in https://dolphinscheduler.apache.org/ but failed in github, for now. Maybe we should find some way to fix it in the further, bu for now is do not matter because https://dolphinscheduler.apache.org/ looking good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] QuakeWang commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1094580622
> Could you give some examples of the bad path image?
Like this, the picture is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1141741481
after https://github.com/apache/dolphinscheduler-website/pull/789 merged, we could change all our img path from `/img` to related path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1143192383
> > after [apache/dolphinscheduler-website#789](https://github.com/apache/dolphinscheduler-website/pull/789) merged, we could change all our img path from `/img` to related path
>
> Do you mean we can use `... /... /... /... /img/tasks/demo/` to replace `/img/tasks/demo` at now ?
Yeah, after https://github.com/apache/dolphinscheduler-website/pull/789 we can do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9426: [Bug] [Doc] Image can not display properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9426:
URL: https://github.com/apache/dolphinscheduler/issues/9426#issuecomment-1130813169
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org