You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/10 05:43:45 UTC

[GitHub] [calcite] danny0405 removed a comment on issue #1703: [CALCITE-2450] Normalize RexCall predicates when computing digest

danny0405 removed a comment on issue #1703: [CALCITE-2450] Normalize RexCall predicates when computing digest
URL: https://github.com/apache/calcite/pull/1703#issuecomment-572882731
 
 
   > @danny0405 , I don't understand what do you mean by `needs-a-final-review` label.
   > The change has been tested both in isolation and with the cost changes, and it behaves well.
   > 
   > I've added the tests and added `try-with-resources` API which simplifies the use, and `ThreadLocal` is now `private`.
   > 
   > So I'm inclined to merge the PR.
   
   The PR looks good from my side, go ahead ~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services