You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Jira)" <ji...@apache.org> on 2022/07/27 16:52:00 UTC

[jira] [Commented] (CASSANDRA-17771) Fix flaky test: org.apache.cassandra.tools.nodetool.TpStatsTest

    [ https://issues.apache.org/jira/browse/CASSANDRA-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572026#comment-17572026 ] 

Brandon Williams commented on CASSANDRA-17771:
----------------------------------------------

||Branch||Circle||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17771-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/562/workflows/93a47808-b3d1-44d3-ae39-84d27c4f3d8b], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/562/workflows/2c91d342-4f68-42a6-a136-4185ff931d6b]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17771-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/563/workflows/99244599-7d91-48fe-973d-615427ecd219], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/563/workflows/1d60c4bb-bb92-45bd-9428-751b4e51669f]|

The problem is this test always expects an echo response, but there's no guarantee that has been processed during this test, so sometimes it fails.  Patch to relax this requirement.

> Fix flaky test: org.apache.cassandra.tools.nodetool.TpStatsTest
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-17771
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17771
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Brandon Williams
>            Priority: Normal
>             Fix For: 4.1-rc, 4.x
>
>
> {code}
> junit.framework.AssertionFailedError: 
> Expecting:
> {code}
> ...
> {code}
> to contain pattern:
>   "ECHO_RSP\D.*[1-9].*"
> 	at org.apache.cassandra.tools.nodetool.TpStatsTest.testTpStats(TpStatsTest.java:137)
> 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org