You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by sa...@apache.org on 2007/03/05 11:59:32 UTC

svn commit: r514646 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Author: sanka
Date: Mon Mar  5 02:59:31 2007
New Revision: 514646

URL: http://svn.apache.org/viewvc?view=rev&rev=514646
Log:
Fixed:

Modified:
    webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java?view=diff&rev=514646&r1=514645&r2=514646
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java Mon Mar  5 02:59:31 2007
@@ -475,7 +475,7 @@
 
                 axisBindingInMessage.setAxisMessage(axisInMessage);
                 axisBindingInMessage.setDirection(axisInMessage.getDirection());
-
+                
                 axisBindingOperation
                         .addChild(axisBindingInMessage.getDirection(), axisBindingInMessage);
             }
@@ -2132,9 +2132,7 @@
             } else if (extElements.get(i) instanceof HTTPBinding) {
                 isHttpBinding = true;
                 this.bindingType = BINDING_TYPE_HTTP;
-            } else {
-                throw new WSDLProcessingException(
-                        "Not supported binding type " + binding.getQName().getLocalPart());
+            
             }
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Re: svn commit: r514646 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Posted by David Illsley <da...@gmail.com>.
Ah, ok. Thanks,
David

On 05/03/07, Amila Suriarachchi <am...@gmail.com> wrote:
>
> hi,
> some days ago, I added an exception throwing part to throw an exception when
> there is an unsuported binding.
>
> eg.
> <wsdl:binding name="versionSOAP11Binding" type="axis2:versionPortType">
>         <soap:binding
> transport="http://schemas.xmlsoap.org/soap/http"
> style="document"   />
> here I made an wrong assumption that the wsdl:binding contontain only the
> binding type extensibility element.
>
> But when integrating with policy, we can have elements like this,
>
> <wsdl:binding name="versionSOAP11Binding" type="axis2:versionPortType">
>          <wsp:Policy
>
> xmlns:wsp="http://schemas.xmlsoap.org/ws/2004/09/policy"
>                  Name="urn:version"
>                  Id="urn:version">
>
>          </wsp:Policy>
>          <soap:binding
> transport="http://schemas.xmlsoap.org/soap/http"
> style="document"   />
>
> In this case above code raises an unnecessary exception.
>
> Amila.
>
> --
> Amila Suriarachchi,
> WSO2 Inc.


-- 
David Illsley - IBM Web Services Development

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: svn commit: r514646 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Posted by Amila Suriarachchi <am...@gmail.com>.
hi,
some days ago, I added an exception throwing part to throw an exception when
there is an unsuported binding.

eg.
<wsdl:binding name="versionSOAP11Binding" type="axis2:versionPortType">
        <soap:binding transport="http://schemas.xmlsoap.org/soap/http"
style="document"   />
here I made an wrong assumption that the wsdl:binding contontain only the
binding type extensibility element.

But when integrating with policy, we can have elements like this,

<wsdl:binding name="versionSOAP11Binding" type="axis2:versionPortType">
        <wsp:Policy
                xmlns:wsp="http://schemas.xmlsoap.org/ws/2004/09/policy"
                Name="urn:version"
                Id="urn:version">

        </wsp:Policy>
        <soap:binding transport="http://schemas.xmlsoap.org/soap/http"
style="document"   />

In this case above code raises an unnecessary exception.

Amila.

-- 
Amila Suriarachchi,
WSO2 Inc.

Re: svn commit: r514646 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Posted by David Illsley <da...@gmail.com>.
Hi sanka,
Could you explain why you've made this change please

On 05/03/07, sanka@apache.org <sa...@apache.org> wrote:
> Author: sanka
> Date: Mon Mar  5 02:59:31 2007
> New Revision: 514646
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=514646
> Log:
> Fixed:
>
> Modified:
>     webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
>
> Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
> URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java?view=diff&rev=514646&r1=514645&r2=514646
> ==============================================================================
> --- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java (original)
> +++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java Mon Mar  5 02:59:31 2007
> @@ -475,7 +475,7 @@
>
>                  axisBindingInMessage.setAxisMessage(axisInMessage);
>                  axisBindingInMessage.setDirection(axisInMessage.getDirection());
> -
> +
>                  axisBindingOperation
>                          .addChild(axisBindingInMessage.getDirection(), axisBindingInMessage);
>              }
> @@ -2132,9 +2132,7 @@
>              } else if (extElements.get(i) instanceof HTTPBinding) {
>                  isHttpBinding = true;
>                  this.bindingType = BINDING_TYPE_HTTP;
> -            } else {
> -                throw new WSDLProcessingException(
> -                        "Not supported binding type " + binding.getQName().getLocalPart());
> +
>              }
>          }
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>


-- 
David Illsley - IBM Web Services Development

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org