You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/14 23:24:38 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #6003: Checkstyle plugin checks test codes

wu-sheng commented on pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#issuecomment-744793121


   The original idea is keeping them separately, as in test cases, we don't want them share anything. Dependency management is the thing we want to avoid, and every scenario will be packaged mutile times for using different library versions.
   
   So, I would say, don't merge them into one to avoid complexity, but add the check plugin for evryone of them. I remember @dmsolr provides a scenario project structure generator? If we change there too, the new scenarios should be easier to follow this new requirement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org