You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/04/08 18:51:54 UTC
Re: Review Request: Fixed master to properly remove a non-checkpointing
framework when a checkpointing slave exits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9945/#review18777
-----------------------------------------------------------
Sounds like the slave could also use some states, e.g.
INITIALIZING
RUNNING
CHECKPOINTING
TERMINATING
- Ben Mahler
On March 15, 2013, 8:37 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9945/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Sending this out before I write any tests, to get feedback on the semantics.
>
>
> Diffs
> -----
>
> src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7
> src/master/master.cpp ecefc8b9fc14b4f0950b053d47bb2d6e464f8724
> src/tests/slave_recovery_tests.cpp a1fa485d917e882ad1d950532758c5978e8fbb05
>
> Diff: https://reviews.apache.org/r/9945/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed master to properly remove a
non-checkpointing framework when a checkpointing slave exits.
Posted by Benjamin Mahler <be...@gmail.com>.
Nice!
On Mon, Apr 8, 2013 at 10:16 AM, Vinod Kone <vi...@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9945/
>
> On April 8th, 2013, 4:51 p.m., *Ben Mahler* wrote:
>
> Sounds like the slave could also use some states, e.g.
> INITIALIZING
> RUNNING
> CHECKPOINTING
> TERMINATING
>
> Yup. Done in another review: https://reviews.apache.org/r/10268/
>
>
> - Vinod
>
> On March 15th, 2013, 8:37 p.m., Vinod Kone wrote:
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> By Vinod Kone.
>
> *Updated March 15, 2013, 8:37 p.m.*
> Description
>
> Sending this out before I write any tests, to get feedback on the semantics.
>
> Testing
>
> make check.
>
> Diffs
>
> - src/master/master.hpp (c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7)
> - src/master/master.cpp (ecefc8b9fc14b4f0950b053d47bb2d6e464f8724)
> - src/tests/slave_recovery_tests.cpp
> (a1fa485d917e882ad1d950532758c5978e8fbb05)
>
> View Diff <https://reviews.apache.org/r/9945/diff/>
>
Re: Review Request: Fixed master to properly remove a non-checkpointing
framework when a checkpointing slave exits.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 8, 2013, 4:51 p.m., Ben Mahler wrote:
> > Sounds like the slave could also use some states, e.g.
> > INITIALIZING
> > RUNNING
> > CHECKPOINTING
> > TERMINATING
Yup. Done in another review: https://reviews.apache.org/r/10268/
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9945/#review18777
-----------------------------------------------------------
On March 15, 2013, 8:37 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9945/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Sending this out before I write any tests, to get feedback on the semantics.
>
>
> Diffs
> -----
>
> src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7
> src/master/master.cpp ecefc8b9fc14b4f0950b053d47bb2d6e464f8724
> src/tests/slave_recovery_tests.cpp a1fa485d917e882ad1d950532758c5978e8fbb05
>
> Diff: https://reviews.apache.org/r/9945/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Vinod Kone
>
>