[GitHub] [arrow] Platob commented on a diff in pull request #35010: GH-35009: [C#] First level ArrayTypes IEnumerable

["Platob (via GitHub)" <gi...@apache.org>]

Platob commented on code in PR #35010:
URL: https://github.com/apache/arrow/pull/35010#discussion_r1163284171


##########
csharp/src/Apache.Arrow/Arrays/StringArray.cs:
##########
@@ -91,5 +93,16 @@ public string GetString(int index, Encoding encoding = default)
                     return encoding.GetString(data, bytes.Length);
             }
         }
+
+        // IEnumerable methods
+        public new IEnumerator<string> GetEnumerator()
+        {
+            return Enumerable.Range(0, Length).Select(i => GetString(i)).GetEnumerator();

Review Comment:
   Ok i was hesitating to do it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org