You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by js...@apache.org on 2003/05/07 19:44:04 UTC
cvs commit: maven/src/plugins-build/eclipse plugin.jelly
jstrachan 2003/05/07 10:44:04
Modified: src/plugins-build/eclipse plugin.jelly
Log:
patch to avoid adding JUnit twice to a generated project file for projects which require JUnit as a dependency
Revision Changes Path
1.13 +3 -0 maven/src/plugins-build/eclipse/plugin.jelly
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/eclipse/plugin.jelly,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- plugin.jelly 8 Apr 2003 12:19:25 -0000 1.12
+++ plugin.jelly 7 May 2003 17:44:03 -0000 1.13
@@ -102,6 +102,9 @@
<j:when test="${eclipseDependency == 'true'}">
<classpathentry kind="src" path="/${lib.dependency.artifactId}"/>
</j:when>
+ <j:when test="${lib.dependency.groupId == 'junit'}">
+ <!-- ignoring junit dependency as we've already created it -->
+ </j:when>
<j:otherwise>
<classpathentry kind="var" path="MAVEN_REPO${lib.urlPath}"/>
</j:otherwise>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/eclipse plugin.jelly
Posted by "Mark H. Wilkinson" <mh...@kremvax.net>.
On Thu, 2003-05-08 at 17:35, James Strachan wrote:
> On Thursday, May 8, 2003, at 10:16 am, Mark H. Wilkinson wrote:
> > On Wed, 2003-05-07 at 18:44, jstrachan@apache.org wrote:
> >> jstrachan 2003/05/07 10:44:04
> >>
> >> Modified: src/plugins-build/eclipse plugin.jelly
> >> Log:
> >> patch to avoid adding JUnit twice to a generated project file for
> >> projects which require JUnit as a dependency
> >
> > That should allow MAVEN-374 to be resolved, shouldn't it?
>
> Not quite - I'd missed that patch (I should try remember to check JIRA
> first before trying to fix something) - though this bug request seems
> to be another fix for inter-project dependencies (which is another
> great thing I'd like too :). Will have a look at the patch tomorrow...
>>From my reading of it, the inter-project dependency change is pretty
much identical to the fix that went into eclipse/plugin.jelly rev 1.12.
Looks like MAVEN-369 should be closed too...
-Mark.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/eclipse plugin.jelly
Posted by James Strachan <ja...@yahoo.co.uk>.
On Thursday, May 8, 2003, at 10:16 am, Mark H. Wilkinson wrote:
> On Wed, 2003-05-07 at 18:44, jstrachan@apache.org wrote:
>> jstrachan 2003/05/07 10:44:04
>>
>> Modified: src/plugins-build/eclipse plugin.jelly
>> Log:
>> patch to avoid adding JUnit twice to a generated project file for
>> projects which require JUnit as a dependency
>
> That should allow MAVEN-374 to be resolved, shouldn't it?
Not quite - I'd missed that patch (I should try remember to check JIRA
first before trying to fix something) - though this bug request seems
to be another fix for inter-project dependencies (which is another
great thing I'd like too :). Will have a look at the patch tomorrow...
James
-------
http://radio.weblogs.com/0112098/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/eclipse plugin.jelly
Posted by "Mark H. Wilkinson" <mh...@kremvax.net>.
On Wed, 2003-05-07 at 18:44, jstrachan@apache.org wrote:
> jstrachan 2003/05/07 10:44:04
>
> Modified: src/plugins-build/eclipse plugin.jelly
> Log:
> patch to avoid adding JUnit twice to a generated project file for
> projects which require JUnit as a dependency
That should allow MAVEN-374 to be resolved, shouldn't it?
-Mark.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org