[GitHub] matthiasblaesing commented on a change in pull request #857: [NETBEANS-1074] Module Review libs.jstestdriver

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #857: [NETBEANS-1074] Module Review libs.jstestdriver
URL: https://github.com/apache/incubator-netbeans/pull/857#discussion_r216735318
 
 

 ##########
 File path: libs.jstestdriver/external/jstestdriver-1.3.5-license.txt
 ##########
 @@ -0,0 +1,20 @@
+Name: JS Test Driver
+Version: 1.3.5
+License: Apache-2.0-REF
 
 Review comment:
   Given, that the referenced license is plain Apache-2.0, I would use that. From my POV it does not matter, that google decided to just reference it, but the intention is clear. The Copyright info is also not relevant here, as the Apache license only requires parts of NOTICE to be repeated.
   
   The binary also bundles several third party jars - it might be worth adding a "Comment: ..." header, that explains, that the file is only downloaded to be part of the classpath when the extension file is compiled (i.e. we don't plan to redistribute it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists