You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/11/16 18:19:12 UTC

[GitHub] sohami commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown

sohami commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r234070327
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
 ##########
 @@ -285,6 +286,10 @@ public synchronized void close() {
       if (storeProvider != profileStoreProvider) {
         AutoCloseables.close(profileStoreProvider);
       }
+      File f = new File(System.getenv("DRILL_PID_DIR") + "/.graceful");
 
 Review comment:
   Provide this as a configuration parameter with default value being `graceful`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services