You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "Christophe Le Saec (Jira)" <ji...@apache.org> on 2023/03/13 15:07:00 UTC
[jira] [Resolved] (AVRO-3721) [Java] Add cache to org.apache.avro.JsonProperties.getObjectProps
[ https://issues.apache.org/jira/browse/AVRO-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Le Saec resolved AVRO-3721.
--------------------------------------
Resolution: Fixed
> [Java] Add cache to org.apache.avro.JsonProperties.getObjectProps
> -----------------------------------------------------------------
>
> Key: AVRO-3721
> URL: https://issues.apache.org/jira/browse/AVRO-3721
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.11.1
> Reporter: Moshe Elisha
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently every time you invoke JsonProperties.getObjectProps on same instance, the code loops over the props and creates a new LinkedHashMap and a new UnmodifiableMap.
>
> In our use case, we store a Protocol (and the JsonProperties) and access the same instances multiple times.
>
> Storing a simple cache "private Map<String, Object> objectProps;" inside JsonProperties will slightly improve performance and memory usage.
> objectProps can be lazy initialized in JsonProperties.getObjectProps and reset when "JsonProperties.addProp(String, JsonNode)" is invoked.
>
> Thanks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)